Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 4 4
Lines 737 739 +2
Branches 165 165
=======================================
+ Hits 735 737 +2
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
Author
|
It is interesting that said test also fails for the other Python versions. I am not convinced this has anything to do with the proposed changes, however.... |
MyrikLD
reviewed
Aug 25, 2021
asvetlov
reviewed
Oct 5, 2021
Member
|
Suggested typos are applied to master in a separate commit, thanks |
asvetlov
approved these changes
Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Added
__bytes__()magic method so thatbytes(url)will work and use optimal ASCII encoding, as URL string representations are always encoded already.While I was at it, I fixed some typos I saw and I had to add a mypy ignore for the tests to work for me. There is one test that fails for me (
test_semicolon_as_separator) because I was using a Python > 3.9.2 andparse_qsl()changed its behavior.Are there changes in behavior for the user?
Existing functionality shouldn't be affected.
Related issue number
n/a
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.