Conversation
9d54557 to
79d3194
Compare
79d3194 to
86197ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 4 4
Lines 768 768
Branches 217 217
=======================================
Hits 766 766
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mjpieters
added a commit
that referenced
this pull request
Apr 19, 2023
mjpieters
added a commit
that referenced
this pull request
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The documentation states that
url.update_query(None)clears the query string.However, that means that other valid arguments, such as
{}, should not.Are there changes in behavior for the user?
This behaviour was recently fixed in #792, but this specific edgecase was then
introduced. We haven't released a version with that change included, however.
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.