add option for childContextTypes of ReactWrapper

[jakubzitny]

Fixes #144.

[lelandrichardson]

should we merge node.type.contextTypes and options.childContextTypes?

[jakubzitny]

Yeah, it's probably better. I'll update this, however, I think there should be better automatic fix to this issue.

[lelandrichardson]

@jakubzitny I suppose you mean by traversing the tree and finding the required context types of the descendants?

I'm really not sure if this is possible. At the time this code executes, the node is only the output of React.createElement() on the root node you are mounting. Traversing it's rendered subtree would require actually rendering, which we can't do until this component is created.

It's possible I'm not fully grokking the way context is working, but i'm unsure how react itself solves this if this is how context works.

[jakubzitny]

@lelandrichardson Yeah I meant something like that. I know it's not really possible without rendering. :(

I was thinking about just looking at the contextTypes of all children somehow. Isn't it really possible to get the children of a component without rendering somehow? By looking at the render function, or just rendering it shallowly, then getting the children from props().children and then rendering shallowly their children, or something like that?

The thing is that in React if you do this, you always specify both childContextTypes and also getChildContext. So it is not handled automatically. But for the test cases with enzyme it'd be great if it was automatic, so you wouldn't need to specify that many things and making the tests longer..

---

Btw I pushed a fixup for merging both childContextTypes. I will rebase it if you want to accept this PR.

[lelandrichardson]

Going to go ahead and merge this in. I think this is the best way to do this at this point. Open to PRs for alternatives though.

[blainekasten]

Is there any specific reason this wasn't built into the shallow wrapper API?

[jakubzitny]

@blainekasten there is no need for it in ShallowWrapper.. (the problem was with context of deeper child nodes, there are none in ShallowWrapper)