More portability fixes

alexcrichton · alexcrichton · commit d62df1749a42 · 2026-04-15T12:45:40.000-07:00
diff --git a/crates/wasi/src/filesystem/unix.rs b/crates/wasi/src/filesystem/unix.rs
@@ -39,7 +39,7 @@ pub(crate) fn advise(file: impl AsFd, offset: u64, len: u64, advice: Advice) ->
                 Advice::DontNeed |
                 Advice::NoReuse => {}
             }
-        } else if #[cfg(target_os = "linux")] {
+        } else if #[cfg(any(target_os = "linux", target_os = "android"))] {
             use std::num::NonZeroU64;
             let advice = match advice {
                 Advice::Normal => rustix::fs::Advice::Normal,
@@ -52,6 +52,7 @@ pub(crate) fn advise(file: impl AsFd, offset: u64, len: u64, advice: Advice) ->
             rustix::fs::fadvise(file, offset, NonZeroU64::new(len), advice)?;
         } else {
             // noop on other platforms
+            let _ = (file, offset, len, advice);
         }
     }
     Ok(())

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ pub(crate) fn advise(file: impl AsFd, offset: u64, len: u64, advice: Advice) ->`
`39`	`39`	`Advice::DontNeed \|`
`40`	`40`	`Advice::NoReuse => {}`
`41`	`41`	`}`
`42`		`- } else if #[cfg(target_os = "linux")] {`
	`42`	`+ } else if #[cfg(any(target_os = "linux", target_os = "android"))] {`
`43`	`43`	`use std::num::NonZeroU64;`
`44`	`44`	`let advice = match advice {`
`45`	`45`	`Advice::Normal => rustix::fs::Advice::Normal,`
`@@ -52,6 +52,7 @@ pub(crate) fn advise(file: impl AsFd, offset: u64, len: u64, advice: Advice) ->`
`52`	`52`	`rustix::fs::fadvise(file, offset, NonZeroU64::new(len), advice)?;`
`53`	`53`	`} else {`
`54`	`54`	`// noop on other platforms`
	`55`	`+ let _ = (file, offset, len, advice);`
`55`	`56`	`}`
`56`	`57`	`}`
`57`	`58`	`Ok(())`