Fixed: Replaced algolia exception by IllegalArgumentException

Author: Ant-hem

algoliasearch-common/src/main/java/com/algolia/search/APIClient.java

@@ -808,9 +808,8 @@ <T> TaskSingleIndex saveObjects(String indexName, List<T> objects, RequestOption
   Task deleteObject(String indexName, String objectID, RequestOptions requestOptions)
       throws AlgoliaException {
 
-    if (objectID.trim().length() == 0)
-    {
-      throw new AlgoliaException("ObjectID must not be empty");
+    if (objectID.trim().length() == 0) {
+      throw new IllegalArgumentException("ObjectID must not be empty");
     }
 
     Task result =

algoliasearch-common/src/main/java/com/algolia/search/AsyncAPIClient.java

@@ -788,12 +788,11 @@ <T> CompletableFuture<AsyncTaskSingleIndex> saveObjects(
         .thenApply(s -> s.setIndex(indexName));
   }
 
-  CompletableFuture<AsyncTask> deleteObject (
-      String indexName, String objectID, RequestOptions requestOptions) throws AlgoliaException {
+  CompletableFuture<AsyncTask> deleteObject(
+      String indexName, String objectID, RequestOptions requestOptions) {
 
-    if (objectID.trim().length() == 0)
-    {
-      throw new AlgoliaException("ObjectID must not be empty");
+    if (objectID.trim().length() == 0) {
+      throw new IllegalArgumentException("ObjectID must not be empty");
     }
 
     return httpClient

algoliasearch-common/src/main/java/com/algolia/search/AsyncObjects.java

@@ -1,6 +1,5 @@
 package com.algolia.search;
 
-import com.algolia.search.exceptions.AlgoliaException;
 import com.algolia.search.objects.RequestOptions;
 import com.algolia.search.objects.tasks.async.AsyncTask;
 import com.algolia.search.objects.tasks.async.AsyncTaskIndexing;
@@ -207,7 +206,7 @@ default CompletableFuture<AsyncTaskSingleIndex> saveObjects(
    * @param objectID the unique identifier of the object to retrieve
    * @return the associated AsyncTask
    */
-  default CompletableFuture<AsyncTask> deleteObject(@Nonnull String objectID) throws AlgoliaException {
+  default CompletableFuture<AsyncTask> deleteObject(@Nonnull String objectID) {
     return deleteObject(objectID, RequestOptions.empty);
   }
 
@@ -218,8 +217,8 @@ default CompletableFuture<AsyncTask> deleteObject(@Nonnull String objectID) thro
    * @param requestOptions Options to pass to this request
    * @return the associated AsyncTask
    */
-  default CompletableFuture<AsyncTask> deleteObject (
-      @Nonnull String objectID, @Nonnull RequestOptions requestOptions) throws AlgoliaException {
+  default CompletableFuture<AsyncTask> deleteObject(
+      @Nonnull String objectID, @Nonnull RequestOptions requestOptions) {
     return getApiClient().deleteObject(getName(), objectID, requestOptions);
   }
 

algoliasearch-tests/src/test/java/com/algolia/search/integration/common/async/AsyncObjectsTest.java

@@ -11,8 +11,6 @@
 import java.util.List;
 import java.util.Optional;
 import java.util.concurrent.CompletableFuture;
-
-import com.algolia.search.exceptions.AlgoliaException;
 import org.junit.Test;
 
 @SuppressWarnings("ConstantConditions")
@@ -135,20 +133,20 @@ public void getObjectsWithAttributesToRetrieve() throws Exception {
     futureAssertThat(result).extracting("name").containsNull();
   }
 
-  @Test(expected = AlgoliaException.class)
-  public void deleteObjectEmptyObjectIdShouldFail() throws AlgoliaException {
+  @Test(expected = IllegalArgumentException.class)
+  public void deleteObjectEmptyObjectIdShouldFail() throws IllegalArgumentException {
     AsyncIndex<AlgoliaObject> index = createIndex(AlgoliaObject.class);
     index.deleteObject("");
   }
 
-  @Test(expected = AlgoliaException.class)
-  public void deleteObjectWhiteSpaceObjectIdShouldFail() throws AlgoliaException {
+  @Test(expected = IllegalArgumentException.class)
+  public void deleteObjectWhiteSpaceObjectIdShouldFail() throws IllegalArgumentException {
     AsyncIndex<AlgoliaObject> index = createIndex(AlgoliaObject.class);
     index.deleteObject("  ");
   }
 
   @Test(expected = NullPointerException.class)
-  public void deleteObjectNullObjectIdShouldFail() throws AlgoliaException {
+  public void deleteObjectNullObjectIdShouldFail() throws NullPointerException {
     AsyncIndex<AlgoliaObject> index = createIndex(AlgoliaObject.class);
     index.deleteObject(null);
   }

algoliasearch-tests/src/test/java/com/algolia/search/integration/common/sync/SyncObjectsTest.java

@@ -131,20 +131,22 @@ public void getObjectsWithAttributesToRetrieve() throws AlgoliaException {
         .isEqualToComparingFieldByField(new AlgoliaObjectWithID("1", null, 5));
   }
 
-  @Test(expected = AlgoliaException.class)
-  public void deleteObjectEmptyObjectIdShouldFail() throws AlgoliaException {
+  @Test(expected = IllegalArgumentException.class)
+  public void deleteObjectEmptyObjectIdShouldFail()
+      throws AlgoliaException, IllegalArgumentException {
     Index<AlgoliaObject> index = createIndex(AlgoliaObject.class);
     index.deleteObject("");
   }
 
-  @Test(expected = AlgoliaException.class)
-  public void deleteObjectWhiteSpaceObjectIdShouldFail() throws AlgoliaException {
+  @Test(expected = IllegalArgumentException.class)
+  public void deleteObjectWhiteSpaceObjectIdShouldFail()
+      throws AlgoliaException, IllegalArgumentException {
     Index<AlgoliaObject> index = createIndex(AlgoliaObject.class);
     index.deleteObject("  ");
   }
 
   @Test(expected = NullPointerException.class)
-  public void deleteObjectNullObjectIdShouldFail() throws AlgoliaException {
+  public void deleteObjectNullObjectIdShouldFail() throws AlgoliaException, NullPointerException {
     Index<AlgoliaObject> index = createIndex(AlgoliaObject.class);
     index.deleteObject(null);
   }