fix(scala): rename local var to avoid named arg shadowing in Scala 3.8.2

Fluf22 · Fluf22 · commit 5ac617ee6f48 · 2026-03-09T14:39:56.000+01:00
Scala 3.8.2 resolves 'additionalProperties = ...' inside copy() to
the local variable instead of the named parameter, causing type mismatch
errors. Rename the local variable from 'additionalProperties' to
'extraProperties' and use dot notation for copy() calls.
diff --git a/clients/algoliasearch-client-scala/build.sbt b/clients/algoliasearch-client-scala/build.sbt
@@ -1,7 +1,7 @@
 organization := "com.algolia"
 name := "algoliasearch-scala"
 description := "Scala client for Algolia Search API"
-scalaVersion := "3.8.2"
+scalaVersion := "2.13.18"
 crossScalaVersions := Seq("2.13.12", "3.6.3")
 Test / publishArtifact := false
 licenses += ("MIT", url("https://opensource.org/licenses/MIT"))
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/abtesting/ErrorBase.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/abtesting/ErrorBase.scala
@@ -43,12 +43,12 @@ class ErrorBaseSerializer extends Serializer[ErrorBase] {
           val obj = Extraction.extract[ErrorBase](jobject)(formats, mf)
 
           val fields = Set("message")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as ErrorBase")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/abtestingv3/ErrorBase.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/abtestingv3/ErrorBase.scala
@@ -43,12 +43,12 @@ class ErrorBaseSerializer extends Serializer[ErrorBase] {
           val obj = Extraction.extract[ErrorBase](jobject)(formats, mf)
 
           val fields = Set("message")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as ErrorBase")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/analytics/ErrorBase.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/analytics/ErrorBase.scala
@@ -48,12 +48,12 @@ class ErrorBaseSerializer extends Serializer[ErrorBase] {
           val obj = Extraction.extract[ErrorBase](jobject)(formats, mf)
 
           val fields = Set("message")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as ErrorBase")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/BaseSearchResponse.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/BaseSearchResponse.scala
@@ -160,12 +160,12 @@ class BaseSearchResponseSerializer extends Serializer[BaseSearchResponse] {
             "queryID",
             "_automaticInsights"
           )
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as BaseSearchResponse")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/CompositionRunSearchResponse.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/CompositionRunSearchResponse.scala
@@ -54,12 +54,12 @@ class CompositionRunSearchResponseSerializer extends Serializer[CompositionRunSe
           val obj = Extraction.extract[CompositionRunSearchResponse](jobject)(formats, mf)
 
           val fields = Set("objectID", "appliedRules")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as CompositionRunSearchResponse")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/CompositionsSearchResponse.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/CompositionsSearchResponse.scala
@@ -50,12 +50,12 @@ class CompositionsSearchResponseSerializer extends Serializer[CompositionsSearch
           val obj = Extraction.extract[CompositionsSearchResponse](jobject)(formats, mf)
 
           val fields = Set("run")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as CompositionsSearchResponse")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/ErrorBase.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/ErrorBase.scala
@@ -48,12 +48,12 @@ class ErrorBaseSerializer extends Serializer[ErrorBase] {
           val obj = Extraction.extract[ErrorBase](jobject)(formats, mf)
 
           val fields = Set("message")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as ErrorBase")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/Hit.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/Hit.scala
@@ -74,12 +74,12 @@ class HitSerializer extends Serializer[Hit] {
           val obj = Extraction.extract[Hit](renamedObject)(formats, mf)
 
           val fields = Set("objectID", "_highlightResult", "_snippetResult", "_rankingInfo", "_distinctSeqID", "_extra")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as Hit")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/HitMetadata.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/HitMetadata.scala
@@ -60,12 +60,12 @@ class HitMetadataSerializer extends Serializer[HitMetadata] {
           val obj = Extraction.extract[HitMetadata](renamedObject)(formats, mf)
 
           val fields = Set("_injectedItemKey")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as HitMetadata")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/ResultsInjectedItemInfoResponse.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/composition/ResultsInjectedItemInfoResponse.scala
@@ -54,12 +54,12 @@ class ResultsInjectedItemInfoResponseSerializer extends Serializer[ResultsInject
           val obj = Extraction.extract[ResultsInjectedItemInfoResponse](jobject)(formats, mf)
 
           val fields = Set("key", "appliedRules")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as ResultsInjectedItemInfoResponse")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/ingestion/ErrorBase.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/ingestion/ErrorBase.scala
@@ -38,12 +38,12 @@ class ErrorBaseSerializer extends Serializer[ErrorBase] {
           val obj = Extraction.extract[ErrorBase](jobject)(formats, mf)
 
           val fields = Set("message")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as ErrorBase")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/ingestion/PushTaskRecords.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/ingestion/PushTaskRecords.scala
@@ -41,12 +41,12 @@ class PushTaskRecordsSerializer extends Serializer[PushTaskRecords] {
           val obj = Extraction.extract[PushTaskRecords](jobject)(formats, mf)
 
           val fields = Set("objectID")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as PushTaskRecords")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/insights/ErrorBase.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/insights/ErrorBase.scala
@@ -46,12 +46,12 @@ class ErrorBaseSerializer extends Serializer[ErrorBase] {
           val obj = Extraction.extract[ErrorBase](jobject)(formats, mf)
 
           val fields = Set("message")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as ErrorBase")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/monitoring/ErrorBase.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/monitoring/ErrorBase.scala
@@ -37,12 +37,12 @@ class ErrorBaseSerializer extends Serializer[ErrorBase] {
           val obj = Extraction.extract[ErrorBase](jobject)(formats, mf)
 
           val fields = Set("message")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as ErrorBase")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/personalization/ErrorBase.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/personalization/ErrorBase.scala
@@ -42,12 +42,12 @@ class ErrorBaseSerializer extends Serializer[ErrorBase] {
           val obj = Extraction.extract[ErrorBase](jobject)(formats, mf)
 
           val fields = Set("message")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as ErrorBase")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/querysuggestions/ErrorBase.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/querysuggestions/ErrorBase.scala
@@ -42,12 +42,12 @@ class ErrorBaseSerializer extends Serializer[ErrorBase] {
           val obj = Extraction.extract[ErrorBase](jobject)(formats, mf)
 
           val fields = Set("message")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as ErrorBase")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/recommend/BaseSearchResponse.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/recommend/BaseSearchResponse.scala
@@ -160,12 +160,12 @@ class BaseSearchResponseSerializer extends Serializer[BaseSearchResponse] {
             "queryID",
             "_automaticInsights"
           )
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as BaseSearchResponse")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/recommend/ErrorBase.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/recommend/ErrorBase.scala
@@ -48,12 +48,12 @@ class ErrorBaseSerializer extends Serializer[ErrorBase] {
           val obj = Extraction.extract[ErrorBase](jobject)(formats, mf)
 
           val fields = Set("message")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as ErrorBase")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/recommend/RecommendHit.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/recommend/RecommendHit.scala
@@ -75,12 +75,12 @@ class RecommendHitSerializer extends Serializer[RecommendHit] {
           val obj = Extraction.extract[RecommendHit](renamedObject)(formats, mf)
 
           val fields = Set("objectID", "_highlightResult", "_snippetResult", "_rankingInfo", "_distinctSeqID", "_score")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as RecommendHit")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/search/BaseSearchResponse.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/search/BaseSearchResponse.scala
@@ -164,12 +164,12 @@ class BaseSearchResponseSerializer extends Serializer[BaseSearchResponse] {
             "queryID",
             "_automaticInsights"
           )
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as BaseSearchResponse")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/search/DictionaryEntry.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/search/DictionaryEntry.scala
@@ -71,12 +71,12 @@ class DictionaryEntrySerializer extends Serializer[DictionaryEntry] {
           val obj = Extraction.extract[DictionaryEntry](jobject)(formats, mf)
 
           val fields = Set("objectID", "language", "word", "words", "decomposition", "state", "`type`")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as DictionaryEntry")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/search/ErrorBase.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/search/ErrorBase.scala
@@ -52,12 +52,12 @@ class ErrorBaseSerializer extends Serializer[ErrorBase] {
           val obj = Extraction.extract[ErrorBase](jobject)(formats, mf)
 
           val fields = Set("message")
-          val additionalProperties = jobject removeField {
+          val extraProperties = jobject removeField {
             case (name, _) if fields.contains(name) => true
             case _                                  => false
           }
-          additionalProperties match {
-            case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))
+          extraProperties match {
+            case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))
             case _                   => obj
           }
         case _ => throw new IllegalArgumentException(s"Can't deserialize $json as ErrorBase")
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/search/Hit.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/search/Hit.scala
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/search/SearchHits.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/search/SearchHits.scala
diff --git a/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/search/SearchSynonymsResponse.scala b/clients/algoliasearch-client-scala/src/main/scala/algoliasearch/search/SearchSynonymsResponse.scala
diff --git a/playground/scala/build.sbt b/playground/scala/build.sbt
diff --git a/templates/scala/serializer.mustache b/templates/scala/serializer.mustache
diff --git a/tests/output/scala/build.sbt b/tests/output/scala/build.sbt
diff --git a/tests/output/scala/src/test/scala/algoliasearch/e2e/InsightsTest.scala b/tests/output/scala/src/test/scala/algoliasearch/e2e/InsightsTest.scala
diff --git a/tests/output/scala/src/test/scala/algoliasearch/requests/InsightsTest.scala b/tests/output/scala/src/test/scala/algoliasearch/requests/InsightsTest.scala

Original file line number	Diff line number	Diff line change
`@@ -160,12 +160,12 @@ class BaseSearchResponseSerializer extends Serializer[BaseSearchResponse] {`
`160`	`160`	`"queryID",`
`161`	`161`	`"_automaticInsights"`
`162`	`162`	`)`
`163`		`- val additionalProperties = jobject removeField {`
	`163`	`+ val extraProperties = jobject removeField {`
`164`	`164`	`case (name, _) if fields.contains(name) => true`
`165`	`165`	`case _ => false`
`166`	`166`	`}`
`167`		`- additionalProperties match {`
`168`		`- case JObject(fieldsList) => obj copy (additionalProperties = Some(fieldsList))`
	`167`	`+ extraProperties match {`
	`168`	`+ case JObject(fieldsList) => obj.copy(additionalProperties = Some(fieldsList))`
`169`	`169`	`case _ => obj`
`170`	`170`	`}`
`171`	`171`	`case _ => throw new IllegalArgumentException(s"Can't deserialize $json as BaseSearchResponse")`