fix(removeHighlightTags): prevent destructuring undefined object#1039
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2673afc:
|
Haroenv
reviewed
Aug 19, 2021
Haroenv
reviewed
Aug 19, 2021
Haroenv
reviewed
Aug 19, 2021
Co-authored-by: Haroen Viaene <hello@haroen.me>
Haroenv
approved these changes
Aug 19, 2021
Contributor
|
Thanks @Haroenv and @shortcuts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In case the indexing isn't optimal, an error is thrown as we are destructuring a possibly null
lvl0.Reproduction
This can happen when using DocSearch with a Netlify x Algolia Crawler index, but also with a DocSearch index: Search for
gein this sandboxSolution
We now use
getAttributeValueByPathto retrieve the attributevalue, and fallback to an empty string if not found (alternatively, we could provide a default value such asDocumentation).