fix(docs): relative apply link#1060
Merged
shortcuts merged 2 commits intoalgolia:nextfrom Oct 14, 2021
lupinitylabs:fix/apply-link-404
Merged
fix(docs): relative apply link#1060shortcuts merged 2 commits intoalgolia:nextfrom lupinitylabs:fix/apply-link-404
shortcuts merged 2 commits intoalgolia:nextfrom
lupinitylabs:fix/apply-link-404
Conversation
The apply link on the what-is-docsearch page resolves to the non-existent https://docsearch.algolia.com/docs/apply URL where it should point to https://docsearch.algolia.com/apply.
|
✔️ Deploy Preview for docsearch ready! 🔨 Explore the source changes: aaee780 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsearch/deploys/6167dafdef601400075522ca 😎 Browse the preview: https://deploy-preview-1060--docsearch.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit aaee780:
|
shortcuts
approved these changes
Oct 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The apply link on the what-is-docsearch page resolves to the non-existent
https://docsearch.algolia.com/docs/applyURL while it should point tohttps://docsearch.algolia.com/apply. This PR fixes the issue by adding a slash in front of the link.(Sorry for not following your contribution guide 100%, as you obviously prefer to have an issue opened first 😅).