fix(DocSearchProps): type searchParameters#1200
Merged
Merged
Conversation
|
✔️ Deploy Preview for docsearch canceled. 🔨 Explore the source changes: 032cb80 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsearch/deploys/61a9fbba561d390008d5c29c |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 032cb80:
|
bodinsamuel
approved these changes
Dec 3, 2021
bodinsamuel
left a comment
bodinsamuel
left a comment
Contributor
There was a problem hiding this comment.
I'll advice to always use strict mode on typescript with no-explicit-any eslint rule
Member
Author
Indeed, I'll add it in a future PR to do a pass on the types, before the stable release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
searchParameterswere not typed