Skip to content

fix(deps): make react an optional peer dependency in @docsearch/react#1273

Merged
shortcuts merged 5 commits into
algolia:mainfrom
brc-dd:patch-1
Aug 15, 2022
Merged

fix(deps): make react an optional peer dependency in @docsearch/react#1273
shortcuts merged 5 commits into
algolia:mainfrom
brc-dd:patch-1

Conversation

@brc-dd

@brc-dd brc-dd commented Jan 16, 2022

Copy link
Copy Markdown
Contributor

fixes (partially) #1272

@netlify

netlify Bot commented Jan 16, 2022

Copy link
Copy Markdown

Deploy Preview for docsearch canceled.

Name Link
🔨 Latest commit 06363c7
🔍 Latest deploy log https://app.netlify.com/sites/docsearch/deploys/62fac1d57bbb550008bd0a33

@codesandbox-ci

codesandbox-ci Bot commented Jan 16, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e1ad16d:

Sandbox Source
Vanilla Configuration

@brc-dd

brc-dd commented Jun 3, 2022

Copy link
Copy Markdown
Contributor Author

Hi @shortcuts! Sorry for pinging you directly. But can this be looked into?

@benmccann

Copy link
Copy Markdown

@brc-dd it looks like this PR needs to be rebased

@shortcuts would you be able to review this PR? It's a major stumbling block to using Algolia with non-React projects like Vue, Svelte, etc. Are there any concerns you have or things we could help test?

@shortcuts shortcuts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm fine with the workaround if we can't apply it at the JS package level

Comment thread packages/docsearch-react/package.json

@shortcuts shortcuts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and investigation!

@shortcuts shortcuts changed the title fix: make react an optional peer dependency in @docsearch/react fix(deps): make react an optional peer dependency in @docsearch/react Aug 15, 2022
@shortcuts shortcuts merged commit eb44d0c into algolia:main Aug 15, 2022
@brc-dd brc-dd deleted the patch-1 branch August 15, 2022 23:49
@benmccann

Copy link
Copy Markdown

Thanks for the merge! Any chance we can get a new release?

@shortcuts

Copy link
Copy Markdown
Member

Thanks for the merge! Any chance we can get a new release?

Hey, it's released in 3.2.1!

@SimenB

SimenB commented Aug 16, 2022

Copy link
Copy Markdown

@shortcuts

Copy link
Copy Markdown
Member

@shortcuts are you sure? 😅

https://www.npmjs.com/package/@docsearch/react

image

Oops, now it's good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants