feat: enable Cmd+K shortcut when caps lock is on#1590
Merged
Conversation
✅ Deploy Preview for docsearch ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
Author
|
friendly ping for @francoischalifour @shortcuts |
shortcuts
reviewed
Oct 22, 2022
shortcuts
left a comment
shortcuts
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! It make sense to me, plus it's also how it works for websites that offers command palette (e.g. GitHub).
Would you mind adding a test here? https://github.com/algolia/docsearch/blob/main/cypress/integration/search/actions.spec.ts#L18
Contributor
Author
|
Oh yes, just added them. |
shortcuts
changed the title
Cmd+K shortcut when caps lock is onCmd+K shortcut when caps lock is on
Member
Thanks!! Will release the new version on Monday! |
shortcuts
approved these changes
Oct 23, 2022
Contributor
Author
|
@shortcuts you didn't forget about the new release? |
Member
.... no @lex111 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search shortcut should be work if even caps lock is on
cc @shortcuts