feat(api): allow insights options to be forwarded to Autocomplete#1904
Merged
Conversation
✅ Deploy Preview for docsearch canceled.
|
8bittitan
requested review from
clemfromspace,
dylantientcheu,
levimichael,
loicsay and
shaneafsar
8bittitan
force-pushed
the
feat/autocomplete-insights
branch
from
d19f176 to
fc69998
Compare
shaneafsar
approved these changes
Jun 6, 2023
francoischalifour
approved these changes
Jun 7, 2023
Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
shortcuts
approved these changes
Jun 8, 2023
shortcuts
left a comment
shortcuts
left a comment
Member
There was a problem hiding this comment.
looks super great!
(don't forget to update the squash commit message so that the release script can catch it as a feat (https://www.conventionalcommits.org/en/v1.0.0/))
8bittitan
changed the title
8bittitan
changed the title
8bittitan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the version of
autocomplete-corethat we are using to allow for sending events within DocSearch.Allowing for events to be sent will unlock more features in the long run for DocSearch and can help give insight into how users are using DocSearch on each site.