Skip to content

feat: add keypress effect to DocSearchButton#2087

Merged
8bittitan merged 3 commits into
algolia:mainfrom
SevenOutman:feat/key-effect
Oct 5, 2023
Merged

feat: add keypress effect to DocSearchButton#2087
8bittitan merged 3 commits into
algolia:mainfrom
SevenOutman:feat/key-effect

Conversation

@SevenOutman

@SevenOutman SevenOutman commented Oct 1, 2023

Copy link
Copy Markdown
Contributor

Add this subtle effect that responds to keypress on Meta/Ctrl and K.

docsearch.mov
docsearch.mov

@netlify

netlify Bot commented Oct 1, 2023 •
edited
Loading

Copy link
Copy Markdown

‼️ Deploy request for docsearch rejected.

Name Link
🔨 Latest commit 46de0f4

@shaneafsar shaneafsar requested a review from 8bittitan October 3, 2023 14:35
@8bittitan

8bittitan commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

Hi @SevenOutman this looks really good! Could you please run yarn test:size in your local and update the bundlesize.config.json accordingly for the CI to pass please? 😄

@SevenOutman

SevenOutman commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

Hi @SevenOutman this looks really good! Could you please run yarn test:size in your local and update the bundlesize.config.json accordingly for the CI to pass please? 😄

Sure. Will do that after coming back from vacation.

@8bittitan

8bittitan commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Hi @SevenOutman this looks really good! Could you please run yarn test:size in your local and update the bundlesize.config.json accordingly for the CI to pass please? 😄

Sure. Will do that after coming back from vacation.

Ah no worries then, I can take care of it for you! And merge this in after 😄

@SevenOutman

SevenOutman commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

Ah no worries then, I can take care of it for you! And merge this in after 😄

That's so helpful. Thanks!

@8bittitan 8bittitan merged commit 4c82640 into algolia:main Oct 5, 2023
@redvlock redvlock mentioned this pull request May 31, 2024
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
@q1blue q1blue mentioned this pull request Jun 26, 2024
Open
@Summonshr Summonshr mentioned this pull request Jun 29, 2024
Open
@Summonshr Summonshr mentioned this pull request Jul 13, 2024
Open
@shortcuts shortcuts mentioned this pull request Aug 5, 2024
Closed
7 tasks
@q1blue q1blue mentioned this pull request Aug 6, 2024
Open
@yangzhen1234 yangzhen1234 mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@8bittitan 8bittitan 8bittitan approved these changes

@shortcuts shortcuts Awaiting requested review from shortcuts shortcuts is a code owner

@francoischalifour francoischalifour Awaiting requested review from francoischalifour

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SevenOutman @8bittitan
⚡