Skip to content

fix(hits): default to hierarchy lvl0 if highlights present#2309

Merged
shortcuts merged 1 commit into
mainfrom
fix/lvl0-not-highlighted
Sep 27, 2024
Merged

fix(hits): default to hierarchy lvl0 if highlights present#2309
shortcuts merged 1 commit into
mainfrom
fix/lvl0-not-highlighted

Conversation

@shortcuts

Copy link
Copy Markdown
Member

https://algolia.atlassian.net/browse/DI-2986

There seems to be a bug on the indexing side which impacts some DocSearch users. This bug has been reported to me by @rickhanlonii and fixed in reactjs/react.dev#7183 temporarily, but we can globally mitigate this issue which also impacts other DocSearch users such as https://vuejs.org/, https://tailwindcss.com/

We now default to the non highlighted lvl0 in case the highlightResult value is not present

You can try this fix by running yarn playground:start on main and this branch:

  • On main (or just https://vuejs.org/), no section appears (cf screenshot 1
  • On this branch (cf screenshot 2)

Screenshot 2024-09-27 at 10 31 16

Screenshot 2024-09-27 at 10 31 53

@shortcuts shortcuts self-assigned this Sep 27, 2024
@netlify

netlify Bot commented Sep 27, 2024

Copy link
Copy Markdown

Deploy Preview for docsearch canceled.

Name Link
🔨 Latest commit 43edc1e
🔍 Latest deploy log https://app.netlify.com/sites/docsearch/deploys/66f66d9e169a9e00085196e3

@morganleroi morganleroi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants