feat(ctrl-click): Enable Ctrl-Click on suggestions#542
Merged
Conversation
This updates the underlying autocomplete.js to a version that passes the selection context (click or keyboard) to the `autocomplete:selected` event. With the default `handleSelected, and in the case of a click, it will do nothing (as each suggestion already being a `<a href>`, it will already follow the link), but manually change the location for keyboard navigation. When a custom `handleSelected` is set though, default browser clicks on suggestions are disabled and only `handleSelected` is called. This is to keep backward compatibility with all the live websites that might already use `handleSelected`.
s-pace
approved these changes
Nov 20, 2018
s-pace
left a comment
s-pace
left a comment
There was a problem hiding this comment.
LGTM. I haven't run it but looks to do what we need
| - `suggestion`, the object representing the current selection. Contains a `.url` | ||
| key representing the destination. | ||
|
|
||
| - `datasetNumber`, this should always equal `1` as DocSearch is searching |
There was a problem hiding this comment.
IMHO we should not document this input if it is not useful with our UI which is already tight with one index only.
Contributor
Author
There was a problem hiding this comment.
The issue is that it's the 3rd parameter out of 4, that was already there before. If I don't document it, it make it look like there are only 3 parameters. And we need to keep it to not break backward compatibility, so I unfortunately have to keep it that way :/
|
@pixelastic can you release it with a new version please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the underlying autocomplete.js to a version that passes
the selection context (click or keyboard) to the
autocomplete:selectedevent.With the default
handleSelected, and in the case of a click, it willdo nothing (as each suggestion already being a
<a href>, it willalready follow the link), but manually change the location for
keyboard navigation.
When a custom
handleSelectedis set though, default browser clickson suggestions are disabled and only
handleSelectedis called. Thisis to keep backward compatibility with all the live websites that
might already use
handleSelected.