Better error message#254
Merged
nellyk merged 1 commit intoamericanexpress:masterfrom Feb 26, 2021
k-yle:patch-1
Merged
Conversation
|
|
anescobar1991
approved these changes
Feb 25, 2021
JamesSingleton
approved these changes
Feb 25, 2021
nellyk
approved these changes
Feb 26, 2021
oneamexbot
added a commit
that referenced
this pull request
Feb 26, 2021
# [4.4.0](v4.3.0...v4.4.0) (2021-02-26) ### Features * better error message ([#254](#254)) ([af44dd4](af44dd4))
Contributor
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
goverdhan07
pushed a commit
to goverdhan07/jest-image-snapshot
that referenced
this pull request
Jul 23, 2023
# [4.4.0](americanexpress/jest-image-snapshot@v4.3.0...v4.4.0) (2021-02-26) ### Features * better error message ([americanexpress#254](americanexpress#254)) ([af44dd4](americanexpress@af44dd4))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Fairly straightforward PR. I was struggling to debug an issue because the original error from
spawnisn't shown to the userHow Has This Been Tested?
Tested in my code, now you can see the error - which was
ENOMEM. Also added better unit testsTypes of Changes
Checklist:
My change requires a change to the documentation and I have updated the documentation accordingly.N/AI have added the Apache 2.0 license header to any new files created.N/AWhat is the Impact to Developers Using Jest-Image-Snapshot?
nicer errors