Merge pull request #5 from wariuni/fix-bug-on-windows

amodm · web-flow · commit a2620121c945 · 2018-03-02T21:49:28.000+05:30
Fix URL opening on windows
diff --git a/src/lib.rs b/src/lib.rs
@@ -100,10 +100,10 @@ fn open_on_macos(browser: Browser, url: &str) -> Result<Output> {
     }
 }
 
-/// Deal with opening of browsers on Windows, using `start link` command
+/// Deal with opening of browsers on Windows, using `start` command
 fn open_on_windows(browser: Browser, url: &str) -> Result<Output> {
     match browser {
-        Browser::Default => Command::new("start").arg("link").arg(url).output(),
+        Browser::Default => Command::new("cmd").arg("/C").arg("start").arg(url).output(),
         _ => Err(Error::new(
                 ErrorKind::NotFound,
                 "Only the default browser is supported on this platform right now"

Original file line number	Diff line number	Diff line change
`@@ -100,10 +100,10 @@ fn open_on_macos(browser: Browser, url: &str) -> Result<Output> {`
`100`	`100`	`}`
`101`	`101`	`}`
`102`	`102`
`103`		-/// Deal with opening of browsers on Windows, using `start link` command
	`103`	+/// Deal with opening of browsers on Windows, using `start` command
`104`	`104`	`fn open_on_windows(browser: Browser, url: &str) -> Result<Output> {`
`105`	`105`	`match browser {`
`106`		`- Browser::Default => Command::new("start").arg("link").arg(url).output(),`
	`106`	`+ Browser::Default => Command::new("cmd").arg("/C").arg("start").arg(url).output(),`
`107`	`107`	`_ => Err(Error::new(`
`108`	`108`	`ErrorKind::NotFound,`
`109`	`109`	`"Only the default browser is supported on this platform right now"`