ios: Re-add nullability check for sharedApplication

Author: madsmtm

src/ios.rs

@@ -7,7 +7,15 @@ use crate::{Browser, BrowserOptions, Error, ErrorKind, Result, TargetType};
 
 /// Returns `UIApplication`
 #[allow(non_snake_case)]
-fn sharedApplication(_mtm: MainThreadMarker) -> Retained<NSObject> {
+fn sharedApplication(mtm: MainThreadMarker) -> Option<Retained<NSObject>> {
+    let _ = mtm;
+    // SAFETY: The signature is correct, and we hold `MainThreadMarker`, so we
+    // know we're on the main thread where it's safe to access the shared
+    // UIApplication.
+    //
+    // NOTE: `sharedApplication` is declared as returning non-NULL, but it
+    // will only do so inside `UIApplicationMain`; if called outside, the
+    // shared application is NULL.
     unsafe { msg_send![class!(UIApplication), sharedApplication] }
 }
 
@@ -37,6 +45,13 @@ pub(super) fn open_browser_internal(
     // ensure we're opening only http/https urls, failing otherwise
     let url = target.get_http_url()?;
 
+    let mtm = MainThreadMarker::new().ok_or_else(|| {
+        Error::new(
+            ErrorKind::Other,
+            "Cannot open URL from a thread that is not the main thread",
+        )
+    })?;
+
     // always return true for a dry run
     if options.dry_run {
         return Ok(());
@@ -46,7 +61,11 @@ pub(super) fn open_browser_internal(
         ErrorKind::Other,
         "UIApplication must be retrieved on the main thread",
     ))?;
-    let app = sharedApplication(mtm);
+
+    let app = sharedApplication(mtm).ok_or(Error::new(
+        ErrorKind::Other,
+        "UIApplication is NULL, perhaps UIApplicationMain has not been executed?",
+    ))?;
 
     // Create ns string class from our string
     let url_string = NSString::from_str(url);