Skip to content
This repository was archived by the owner on Aug 27, 2022. It is now read-only.

Commit 8e1b75b

Browse files
committed
[BUG] config: remove numbered image naming option
Currently we're counting the files inside the images folder or reading database lenght to get the image name. We are not really checking for the next available number which could cause that we're loosing made images. - Example 1: We have 3 images: 0001.jpg, 0002.jpg and 0003.jpg Next image-name will be named 0004.jpg *Everything is fine here* - Example 2: We have 2 images: 0001.jpg and 0003.jpg Next image-name will be named 0003.jpg! *This will override the already existing 0003.jpg!* Since i have no quick solution, let's disable numbered image naming for now. Change-Id: I9cf31117bc53bfc89b22c22128dd3076d5f65bde
1 parent 41d4c9e commit 8e1b75b

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

config/config.inc.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
// specify key id (e.g. 13 is the enter key) to use that key to take a picture (picture key)
6464
// use for example https://keycode.info to get the key code
6565
$config['picture']['key'] = null;
66-
// possible naming values: 'dateformatted', 'numbered', 'random'
66+
// possible naming values: 'dateformatted', 'random'
6767
$config['picture']['naming'] = 'dateformatted';
6868
// permissions example values: '0644' (rw-r--r--), '0666' (rw-rw-rw-), '0600' (rw-------)
6969
$config['picture']['permissions'] = '0644';

lib/configsetup.inc.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,6 @@
435435
'placeholder' => $defaultConfig['picture']['naming'],
436436
'options' => [
437437
'dateformatted' => 'Date formatted',
438-
'numbered' => 'Numbered',
439438
'random' => 'Random',
440439
],
441440
'value' => $config['picture']['naming'],

resources/lang/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@
316316
"manual:pictures:picture_frame": "Enter the path of the frame which is applied to your picture after taking it.",
317317
"manual:pictures:picture_keep_original": "If enabled, original images will be kept inside tmp folder.",
318318
"manual:pictures:picture_key": "Specify the key id to use that key to take a picture (e.g. 13 is the enter key). For example use <a href=\"https://keycode.info\" target=\"_blank\">https://keycode.info</a> to find out the key id.",
319-
"manual:pictures:picture_naming": "Choose between date formatted, numbered or random named images. For date formatted images, you can display the image with the date and time inside the gallery.",
319+
"manual:pictures:picture_naming": "Choose between date formatted or random named images. For date formatted images, you can display the image with the date and time inside the gallery.",
320320
"manual:pictures:picture_no_cheese": "If enabled, pictures will be taken right after the countdown. This skips the \"Cheeeeeeeese!\" message.",
321321
"manual:pictures:picture_permissions": "Change taken picture permissions with \"chmod\" command. Please only change this value if you are familiar with file permissions in Linux/Unix.",
322322
"manual:pictures:picture_polaroid_effect": "If enabled, a polaroid effect is applied to your picture after it was taken.",

0 commit comments

Comments
 (0)