Skip to content

Commit 192ec9d

Browse files
committed
Restored class name in error messages [skip ci]
1 parent 0f9775d commit 192ec9d

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

lib/strong_migrations/adapters/abstract_adapter.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,14 @@ def target_version(target_version)
5555
# but connection.pool.spec.name always returns "primary"
5656
# in migrations with rails db:migrate
5757
if ActiveRecord::VERSION::STRING.to_f < 6.1
58-
raise StrongMigrations::Error, "target_version does not support multiple databases for Active Record < 6.1"
58+
# error class is hidden in db:migrate output so ensure message is descriptive
59+
raise StrongMigrations::Error, "StrongMigrations.target_version does not support multiple databases for Active Record < 6.1"
5960
end
6061

6162
db_config_name = connection.pool.db_config.name
6263
target_version.stringify_keys.fetch(db_config_name) do
63-
raise StrongMigrations::Error, "target_version is not configured for :#{db_config_name} database"
64+
# error class is hidden in db:migrate output so ensure message is descriptive
65+
raise StrongMigrations::Error, "StrongMigrations.target_version is not configured for :#{db_config_name} database"
6466
end.to_s
6567
else
6668
target_version.to_s

test/multiple_databases_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ def test_unsupported
88
error = assert_raises(StrongMigrations::Error) do
99
assert_safe AddColumnDefault
1010
end
11-
assert_equal "target_version does not support multiple databases for Active Record < 6.1", error.message
11+
assert_equal "StrongMigrations.target_version does not support multiple databases for Active Record < 6.1", error.message
1212
end
1313
end
1414

@@ -37,7 +37,7 @@ def test_target_version_unconfigured
3737
end
3838
end
3939
end
40-
assert_equal "target_version is not configured for :animals database", error.message
40+
assert_equal "StrongMigrations.target_version is not configured for :animals database", error.message
4141
end
4242

4343
private

0 commit comments

Comments
 (0)