Added Java SemVer for JS API

Author: krmanik

AnkiDroid/build.gradle

@@ -266,4 +266,7 @@ dependencies {
     androidTestImplementation 'androidx.test.ext:junit:1.1.1'
     androidTestImplementation 'androidx.test:rules:1.2.0'
     androidTestImplementation 'org.smali:dexlib2:2.4.0'
+
+    //For AnkiDroid JS API Versioning
+    implementation "com.github.zafarkhaja:java-semver:0.9.0"
 }

AnkiDroid/src/main/java/com/ichi2/anki/AbstractFlashcardViewer.java

@@ -144,6 +144,8 @@
 import static com.ichi2.anki.cardviewer.ViewerCommand.*;
 import static com.ichi2.anki.reviewer.CardMarker.*;
 
+import com.github.zafarkhaja.semver.Version;
+
 @SuppressWarnings({"PMD.AvoidThrowingRawExceptionTypes","PMD.FieldDeclarationsShouldBeAtStartOfClass"})
 public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity implements ReviewerUi, CommandProcessor {
 
@@ -3492,85 +3494,17 @@ private void showDeveloperContact() {
         snackbar.show();
     }
 
-    /*
-     * AnkiDroid JavaScript API Class for major, minor, patch version eg: 1.2.3
-     *  major version : 1
-     *  minor version : 2
-     *  patch version : 3
-     *
+    /**
      * Supplied api version must be equal to current api version to call mark card, toggle flag functions etc.
-     * https://stackoverflow.com/questions/198431/how-do-you-compare-two-version-strings-in-java/27891752
      */
-    public class Version implements Comparable<Version> {
-
-        private String version;
-
-        public final String get() {
-            return this.version;
-        }
-
-        public Version(String version) {
-            if (version == null) {
-                throw new IllegalArgumentException("Version can not be null");
-            }
-            if (!version.matches("[0-9]+(\\.[0-9]+)*")) {
-                UIUtils.showThemedToast(AbstractFlashcardViewer.this, getString(R.string.valid_js_api_version, sCurrentJsApiVersion), false);
-                throw new IllegalArgumentException("Invalid version format");
-            }
-            this.version = version;
-        }
-
-        @Override
-        public int compareTo(Version that) {
-            if (that == null) {
-                return 1;
-            }
-
-            String[] thisParts = this.get().split("\\.");
-            String[] thatParts = that.get().split("\\.");
-            int length = Math.max(thisParts.length, thatParts.length);
-
-            for (int i = 0; i < length; i++) {
-                int thisPart = i < thisParts.length ? Integer.parseInt(thisParts[i]) : 0;
-                int thatPart = i < thatParts.length ? Integer.parseInt(thatParts[i]) : 0;
-
-                if (thisPart < thatPart) {
-                    return -1;
-                }
-
-                if (thisPart > thatPart) {
-                    return 1;
-                }
-            }
-            return 0;
-        }
-
-        @Override
-        public boolean equals(Object that) {
-            if (this == that) {
-                return true;
-            }
-
-            if (that == null) {
-                return false;
-            }
-
-            if (this.getClass() != that.getClass()) {
-                return false;
-            }
-
-            return this.compareTo((Version) that) == 0;
-        }
-    }
-
     private boolean requireApiVersion(String apiVer) {
 
-        Version mVersionCurrent = new Version(sCurrentJsApiVersion);
-        Version mVersionSupplied = new Version(apiVer);
+        Version mVersionCurrent = Version.valueOf(sCurrentJsApiVersion);
+        Version mVersionSupplied = Version.valueOf(apiVer);
 
         if (mVersionCurrent.equals(mVersionSupplied)) {
             return true;
-        } else if (mVersionCurrent.compareTo(mVersionSupplied) == 1) {   // mCurrent > mSupplied
+        } else if (mVersionCurrent.greaterThan(mVersionSupplied)) {
             UIUtils.showThemedToast(AbstractFlashcardViewer.this, getString(R.string.update_js_api_version, sCurrentJsApiVersion), false);
             return false;
         } else {