Deprecate noteId var from getNoteTags in Js-API

Author: Haz3-jolt

AnkiDroid/src/main/assets/scripts/js-api.js

@@ -129,7 +129,7 @@ Object.keys(jsApiList).forEach(method => {
         return;
     }
     if (method === "ankiSetNoteTags") {
-        AnkiDroidJS.prototype[method] = async function (noteId, tags) {
+        AnkiDroidJS.prototype[method] = async function (tags) {
             let hasSpaces = false;
             for (let i = 0; i < tags.length; i++) {
                 tags[i] = tags[i].trim();
@@ -147,14 +147,6 @@ Object.keys(jsApiList).forEach(method => {
         };
         return;
     }
-    if (method === "ankiGetNoteTags") {
-        AnkiDroidJS.prototype[method] = async function (noteId) {
-            const endpoint = jsApiList[method];
-            const data = JSON.stringify({ noteId });
-            return await this.handleRequest(endpoint, data);
-        };
-        return;
-    }
     if (method === "ankiTtsSpeak") {
         AnkiDroidJS.prototype[method] = async function (text, queueMode = 0) {
             const endpoint = jsApiList[method];

AnkiDroid/src/main/java/com/ichi2/anki/AnkiDroidJsAPI.kt

@@ -380,7 +380,7 @@ open class AnkiDroidJsAPI(
 
             "setNoteTags" -> {
                 val jsonObject = JSONObject(apiParams)
-                val noteId = jsonObject.getLong("noteId")
+                val noteId = currentCard.nid
                 val tags = jsonObject.getJSONArray("tags")
                 withCol {
                     fun Note.setTagsFromList(tagList: List<String>) {
@@ -403,8 +403,7 @@ open class AnkiDroidJsAPI(
             }
 
             "getNoteTags" -> {
-                val jsonObject = JSONObject(apiParams)
-                val noteId = jsonObject.getLong("noteId")
+                val noteId = currentCard.nid
                 val noteTags =
                     withCol {
                         getNote(noteId).tags

AnkiDroid/src/test/java/com/ichi2/anki/AnkiDroidJsAPITest.kt

@@ -428,7 +428,7 @@ class AnkiDroidJsAPITest : RobolectricTest() {
 
             // test get tags for note
             val expectedTags = n.tags
-            val response = getDataFromRequest("getNoteTags", jsapi, jsonObjectOf("noteId" to n.id))
+            val response = getDataFromRequest("getNoteTags", jsapi)
             val jsonResponse = JSONObject(response)
             val actualTags = JSONArray(jsonResponse.getString("value"))