Skip to content

Commit dfb8fea

Browse files
authored
Make ignore_unreachable accept jinja templates (#4120)
1 parent 9ee0c98 commit dfb8fea

File tree

6 files changed

+371
-16
lines changed

6 files changed

+371
-16
lines changed

src/ansiblelint/schemas/ansible.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@
168168
},
169169
"ignore_unreachable": {
170170
"title": "Ignore Unreachable",
171-
"type": "boolean"
171+
"$ref": "#/$defs/templated-boolean"
172172
},
173173
"module_defaults": {
174174
"title": "Module Defaults"
@@ -528,7 +528,7 @@
528528
},
529529
"ignore_unreachable": {
530530
"title": "Ignore Unreachable",
531-
"type": "boolean"
531+
"$ref": "#/$defs/templated-boolean"
532532
},
533533
"max_fail_percentage": {
534534
"title": "Max Fail Percentage",
@@ -732,7 +732,7 @@
732732
},
733733
"ignore_unreachable": {
734734
"title": "Ignore Unreachable",
735-
"type": "boolean"
735+
"$ref": "#/$defs/templated-boolean"
736736
},
737737
"module_defaults": {
738738
"title": "Module Defaults"
@@ -935,7 +935,7 @@
935935
},
936936
"ignore_unreachable": {
937937
"title": "Ignore Unreachable",
938-
"type": "boolean"
938+
"$ref": "#/$defs/templated-boolean"
939939
},
940940
"listen": {
941941
"anyOf": [

src/ansiblelint/schemas/playbook.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,8 @@
171171
"$ref": "#/$defs/ignore_errors"
172172
},
173173
"ignore_unreachable": {
174-
"title": "Ignore Unreachable",
175-
"type": "boolean"
174+
"$ref": "#/$defs/templated-boolean",
175+
"title": "Ignore Unreachable"
176176
},
177177
"module_defaults": {
178178
"title": "Module Defaults"
@@ -537,8 +537,8 @@
537537
"$ref": "#/$defs/ignore_errors"
538538
},
539539
"ignore_unreachable": {
540-
"title": "Ignore Unreachable",
541-
"type": "boolean"
540+
"$ref": "#/$defs/templated-boolean",
541+
"title": "Ignore Unreachable"
542542
},
543543
"max_fail_percentage": {
544544
"$ref": "#/$defs/templated-integer",
@@ -747,8 +747,8 @@
747747
"$ref": "#/$defs/ignore_errors"
748748
},
749749
"ignore_unreachable": {
750-
"title": "Ignore Unreachable",
751-
"type": "boolean"
750+
"$ref": "#/$defs/templated-boolean",
751+
"title": "Ignore Unreachable"
752752
},
753753
"module_defaults": {
754754
"title": "Module Defaults"
@@ -947,8 +947,8 @@
947947
"$ref": "#/$defs/ignore_errors"
948948
},
949949
"ignore_unreachable": {
950-
"title": "Ignore Unreachable",
951-
"type": "boolean"
950+
"$ref": "#/$defs/templated-boolean",
951+
"title": "Ignore Unreachable"
952952
},
953953
"include": {
954954
"$ref": "#/$defs/removed-include-module"

src/ansiblelint/schemas/tasks.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@
123123
"$ref": "#/$defs/ignore_errors"
124124
},
125125
"ignore_unreachable": {
126-
"title": "Ignore Unreachable",
127-
"type": "boolean"
126+
"$ref": "#/$defs/templated-boolean",
127+
"title": "Ignore Unreachable"
128128
},
129129
"module_defaults": {
130130
"title": "Module Defaults"
@@ -382,8 +382,8 @@
382382
"$ref": "#/$defs/ignore_errors"
383383
},
384384
"ignore_unreachable": {
385-
"title": "Ignore Unreachable",
386-
"type": "boolean"
385+
"$ref": "#/$defs/templated-boolean",
386+
"title": "Ignore Unreachable"
387387
},
388388
"include": {
389389
"$ref": "#/$defs/removed-include-module"
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
---
2+
- name: Test
3+
hosts: localhost
4+
tasks:
5+
- name: Debug
6+
ansible.builtin.debug:
7+
msg: ignore_unreachable should not be a string
8+
ignore_unreachable: "yes"
9+
10+
- name: Debug
11+
ansible.builtin.debug:
12+
msg: jinja evaluation should not be a string
13+
ignore_unreachable: 123

0 commit comments

Comments
 (0)