[Rebase] [ENG-9177] Removed ember (CenterForOpenScience#11531)

* removed ember mentions of ember in docker and readme

* removed ember-related constants, flags, tests and functionality

* fixed redirects to unexisting index and dashboard flask views

* fixed redirects

* added redirect for removed views

* removed assert for duplicated redirect as it'll be handled by angular

* fix imports after notification refactor

* fix tests

* remove edit_draft_registration_page and new_draft_registration views

---------

Co-authored-by: Ihor Sokhan <isokhan@exoft.net>

Author: antkryt

framework/auth/campaigns.py

@@ -96,7 +96,7 @@ def get_campaigns():
                 'agu_conference_2023': {
                     'system_tag': CampaignSourceTags.AguConference2023.value,
                     'redirect_url': furl(DOMAIN).add(path='my_projects/').url,
-                    'confirmation_email_template': NotificationTypeEnum.USER_CONFIRM_EMAIL,  # added as a placeholder as removed NotificationType
+                    'confirmation_email_template': NotificationType.Type.USER_CAMPAIGN_CONFIRM_EMAIL_AGU_CONFERENCE_2023,
                     'login_type': 'native',
                 }
             })
@@ -105,7 +105,7 @@ def get_campaigns():
                 'agu_conference': {
                     'system_tag': CampaignSourceTags.AguConference.value,
                     'redirect_url': furl(DOMAIN).add(path='my_projects/').url,
-                    'confirmation_email_template': NotificationTypeEnum.USER_CAMPAIGN_CONFIRM_EMAIL_AGU_CONFERENCE,
+                    'confirmation_email_template': NotificationType.Type.USER_CAMPAIGN_CONFIRM_EMAIL_AGU_CONFERENCE,
                     'login_type': 'native',
                 }
             })

framework/auth/views.py

@@ -83,7 +83,7 @@ def _reset_password_get(auth, uid=None, token=None, institutional=False):
         }
         raise HTTPError(http_status.HTTP_400_BAD_REQUEST, data=error_data)
 
-    # override routes.py login_url to redirect to my-projects
+    # override routes.py login_url to redirect to myprojects
     service_url = web_url_for('my_projects', _absolute=True)
 
     return {
@@ -174,7 +174,7 @@ def forgot_password_get(auth):
     if auth.logged_in:
         return auth_logout(redirect_url=request.url)
 
-    #overriding the routes.py sign in url to redirect to the my-projects after login
+    #overriding the routes.py sign in url to redirect to the myprojects after login
     context = {}
     context['login_url'] = web_url_for('my_projects', _absolute=True)
 
@@ -408,7 +408,7 @@ def auth_login(auth):
         if campaign and logged out, go to campaign register page (with next_url if presents)
         if next_url and logged in, go to next url
         if next_url and logged out, go to cas login page with current request url as service parameter
-        if none, go to `/my-projects` which is decorated by `@must_be_logged_in`
+        if none, go to `/myprojects` which is decorated by `@must_be_logged_in`
 
     :param auth: the auth context
     :return: redirects
@@ -435,7 +435,7 @@ def auth_register(auth):
         if next_url and logged in, go to next url
         if next_url and logged out, go to cas login page with current request url as service parameter
         if next_url and logout flag, log user out first and then go to the next_url
-        if none, go to `/my-projects` which is decorated by `@must_be_logged_in`
+        if none, go to `/myprojects` which is decorated by `@must_be_logged_in`
 
     :param auth: the auth context
     :return: land, redirect or `auth_logout`
@@ -995,7 +995,7 @@ def resend_confirmation_post(auth):
                     try:
                         send_confirm_email(user, clean_email, renew=True)
                     except KeyError:
-                        # already confirmed, redirect to my-projects
+                        # already confirmed, redirect to myprojects
                         status_message = f'This email {clean_email} has already been confirmed.'
                         kind = 'warning'
                     user.email_last_sent = timezone.now()

tests/test_auth.py

@@ -96,7 +96,7 @@ def test_confirm_email(self):
             res = self.app.resolve_redirect(res)
 
             assert res.status_code == 302
-            assert '/my-projects/' == urlparse(res.location).path
+            assert '/myprojects/' == urlparse(res.location).path
         # assert len(get_session()['status']) == 1
 
     def test_get_user_by_id(self):

tests/test_misc_views.py

@@ -420,10 +420,8 @@ def test_external_login_confirm_email_get_link(self):
         self.user.save()
         assert not self.user.is_registered
         url = self.user.get_confirmation_url(self.user.username, external_id_provider='orcid', destination='my_projects')
-        with capture_notifications() as notifications:
+        with capture_notifications():
             res = self.app.get(url)
-        assert len(notifications['emits']) == 1
-        assert notifications['emits'][0]['type'] == NotificationTypeEnum.USER_EXTERNAL_LOGIN_LINK_SUCCESS
         assert res.status_code == 302, 'redirects to cas login'
         assert 'You should be redirected automatically' in str(res.html)
         assert '/login?service=' in res.location

tests/test_project_contributor_views.py

@@ -453,7 +453,7 @@ def test_private_project_remove_self_not_admin(self):
         )
         self.project.reload()
         assert res.status_code == 200
-        assert res.json['redirectUrl'] == '/my-projects/'
+        assert res.json['redirectUrl'] == '/myprojects/'
         assert self.user2._id not in self.project.contributors
 
     def test_public_project_remove_self_not_admin(self):

tests/test_webtests.py

@@ -79,7 +79,7 @@ def test_can_see_profile_url(self):
         res = self.app.get(self.user.url, follow_redirects=True)
         assert self.user.url in res.text
 
-    # `GET /login/` without parameters is redirected to `/my-projects/` page which has `@must_be_logged_in` decorator
+    # `GET /login/` without parameters is redirected to `/myprojects/` page which has `@must_be_logged_in` decorator
     # if user is not logged in, she/he is further redirected to CAS login page
     def test_is_redirected_to_cas_if_not_logged_in_at_login_page(self):
         res = self.app.resolve_redirect(self.app.get('/login/'))
@@ -90,7 +90,7 @@ def test_is_redirected_to_cas_if_not_logged_in_at_login_page(self):
     def test_is_redirected_to_myprojects_if_already_logged_in_at_login_page(self):
         res = self.app.get('/login/', auth=self.user.auth)
         assert res.status_code == 302
-        assert 'my-projects' in res.headers.get('Location')
+        assert 'myprojects' in res.headers.get('Location')
 
     def test_register_page(self):
         res = self.app.get('/register/')
@@ -99,7 +99,7 @@ def test_register_page(self):
     def test_is_redirected_to_myprojects_if_already_logged_in_at_register_page(self):
         res = self.app.get('/register/', auth=self.user.auth)
         assert res.status_code == 302
-        assert 'my-projects' in res.headers.get('Location')
+        assert 'myprojects' in res.headers.get('Location')
 
     def test_sees_projects_in_her_dashboard(self):
         # the user already has a project

website/profile/views.py

@@ -25,7 +25,7 @@
 from framework.status import push_status_message
 from framework.utils import throttle_period_expired
 
-from osf.models import ApiOAuth2Application, ApiOAuth2PersonalToken, OSFUser, NotificationTypeEnum
+from osf.models import ApiOAuth2Application, ApiOAuth2PersonalToken, OSFUser, NotificationType
 from osf.exceptions import BlockedEmailError, OSFError
 from osf.utils.requests import string_type_request_headers
 from website import mailchimp_utils

website/routes.py

@@ -50,6 +50,7 @@
 from website.policies import views as policy_views
 from website.preprints import views as preprint_views
 from website.registries import views as registries_views
+from website.notifications import views as notification_views
 from website.closed_challenges import views as closed_challenges_views
 from website.identifiers import views as identifier_views
 

website/views.py

@@ -20,7 +20,7 @@
 from addons.osfstorage.models import Region, OsfStorageFile
 
 from osf import exceptions
-from osf.models import Guid, Preprint, AbstractNode, Node, DraftNode, Registration
+from osf.models import Guid, Preprint, AbstractNode, Node, DraftNode
 
 from website.settings import DOMAIN
 from website.project.decorators import check_contributor_auth
@@ -165,11 +165,11 @@ def paginate(items, total, page, size):
 
 
 def index():
-    return redirect('/my-projects/')
+    return redirect('/myprojects/')
 
 
 def dashboard():
-    return redirect('/my-projects/')
+    return redirect('/myprojects/')
 
 
 def reproducibility():
@@ -287,7 +287,7 @@ def resolve_guid(guid, suffix=None):
     if clean_suffix == 'metadata':
         format_arg = request.args.get('format')
         if format_arg:
-            return guid_metadata_download(guid, resource=resource, metadata_format=format_arg)
+            return guid_metadata_download(guid, resource, format_arg)
 
     if isinstance(resource, Preprint) and resource.provider.domain_redirect_enabled:
         return redirect(resource.absolute_url, http_status.HTTP_301_MOVED_PERMANENTLY)