Test execution_plans::shuffle_writer::tests::test Fail

[Ted-Jiang]

Describe the bug

run cargo test --no-default-features --features sled

To Reproduce
Steps to reproduce the behavior:

Expected behavior
All test pass

Additional context

[Ted-Jiang]

I debug the code, find create_hashes func go into #[cfg(feature = "force_hash_collisions")]
I set #[cfg(not(feature = "force_hash_collisions"))] at the head of the test func still not work

[Ted-Jiang]

@alamb Sorry for bother you, could you have a look?

[alamb]

Ho @Ted-Jiang -- I am not familiar with ballista. Do the tests pass for you if you remove the --features sled option?

It seems like @edrevo or @andygrove may be more familiar with this code

[alamb]

FWIW when I run cargo test --no-default-features --features sled locally (mac, Rust 1.55) I do not see any failures

[Ted-Jiang]

@alamb Thanks. It works for me to update rustc version from 1.54 to 1.55

I think its good to notify what version should use in Readme (or i not found it).

[alamb]

Yeah, we should definitely make it clear that we only test on the latest rust (whatever that happens to be). At this point we just don't have the maintenance bandwidth to maintain compatibility with older rust versions

[alamb]

Filed #1043 to track the doc improvement. Thanks for the report @Ted-Jiang . Closing this one for now

[Ted-Jiang]

Feel glad to help the community become better.