[breaking change] fix 265, log should be log10, and add ln#271
Merged
alamb merged 1 commit intoapache:masterfrom May 6, 2021
Merged
[breaking change] fix 265, log should be log10, and add ln#271alamb merged 1 commit intoapache:masterfrom
alamb merged 1 commit intoapache:masterfrom
Conversation
jimexist
changed the title
jimexist
changed the title
jimexist
changed the title
alamb
reviewed
May 5, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I think this is a good fix personally.
I recommend we add some sort of end to end sql test that runs these functions and compares the results, but otherwise 👍 from me. Any thoughts @jorgecarleitao or @seddonm1 ?
| unary_scalar_expr!(Abs, abs); | ||
| unary_scalar_expr!(Signum, signum); | ||
| unary_scalar_expr!(Exp, exp); | ||
| unary_scalar_expr!(Log, ln); |
Contributor
There was a problem hiding this comment.
perhaps we should keep a log entry / alias to log10 for postgres compatibility?
Member
Author
There was a problem hiding this comment.
i guess it's kept at the https://github.com/apache/arrow-datafusion/pull/271/files#diff-97178da6c90bfcb5e3dc80f06248ac1aebdec5a0e0e1d8ea235e2f571b5badf8R227 level, not here.
Member
Author
There was a problem hiding this comment.
here the macro defs shall not allow dups
Contributor
There was a problem hiding this comment.
Definitely in favour of Postgres behaviour. 👍
jorgecarleitao
approved these changes
May 5, 2021
jimexist
changed the title
Member
Author
alamb
approved these changes
May 6, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I gave it a little spin and it looks good. Thank you @jimexist !
> CREATE EXTERNAL TABLE t(a double) STORED AS CSV LOCATION '/tmp/foo.csv';
0 rows in set. Query took 0 seconds.
> select * from t;
+---------+
| a |
+---------+
| 1 |
| 2 |
| 3 |
| 3.14159 |
+---------+
4 row in set. Query took 0 seconds.
> select log(a), log10(a) from t;
+---------------------+---------------------+
| log(a) | log10(a) |
+---------------------+---------------------+
| 0 | 0 |
| 0.3010299956639812 | 0.3010299956639812 |
| 0.47712125471966244 | 0.47712125471966244 |
| 0.4971495058611233 | 0.4971495058611233 |
+---------------------+---------------------+
houqp
added
ballista
bug
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
* fix: Fix arrow error when sorting on empty batch * Add RecordBatchOptions for Expand
H0TB0X420
pushed a commit
to H0TB0X420/datafusion
that referenced
this pull request
Oct 7, 2025
* Introduce to_variant trait function to LogicalNode and create Explain LogicalNode bindings * Cargo fmt * bindings for Extension LogicalNode * Add missing classes to list of exports so test_imports will pass * Update to point to proper repo * Update pytest to adhere to aggregate calls being wrapped in projections * Address linter change which causes a pytest to fail * Add bindings for LogicalPlan::CreateMemoryTable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example
Closes #123indicates that this PR will close issue #123.Closes #265.
Rationale for this change
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
What changes are included in this PR?
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please add the
breaking changelabel.