MINOR: Fix integration tests by adding datafusion-cli module to docker image#322
Merged
alamb merged 1 commit intoapache:masterfrom May 12, 2021
Merged
MINOR: Fix integration tests by adding datafusion-cli module to docker image#322alamb merged 1 commit intoapache:masterfrom
alamb merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master apache/arrow-datafusion#322 +/- ##
=======================================
Coverage 76.19% 76.19%
=======================================
Files 141 141
Lines 23786 23786
=======================================
Hits 18123 18123
Misses 5663 5663 Continue to review full report at Codecov.
|
alamb
approved these changes
May 12, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me. I didn't test it but 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent changes to move DataFusion CLI to a separate crate broke the Ballista integration tests. This PR simply adds this crate to the Docker image used by the integration tests.
For anyone that is interested, integration tests can be run with this command:
I filed apache/datafusion-ballista#24 for adding these tests to CI