update cargo.toml in python crate and fix unit test due to hash joins#483
update cargo.toml in python crate and fix unit test due to hash joins#483alamb merged 3 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
=======================================
Coverage 75.80% 75.80%
=======================================
Files 153 153
Lines 25924 25924
=======================================
Hits 19652 19652
Misses 6272 6272 Continue to review full report at Codecov.
|
|
@jimexist , could we consider reverting this PR? I do not think that this is correct: DataFusions' behavior of returning 4 record batches when evaluated over a record batch of 3 entries seems wrong to me. |
|
I flagged this in #523 , and I think that we should address this on the DataFusion side and not on the python bindings (i.e. concatenating the arrays). |
|
Scratch the above, Python should keep the tests as is. If anything, we need to address this on DataFusion, but this PR is great as is. Sorry for the noise. |
Which issue does this PR close?
update cargo.toml in python crate
related #481
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?