Skip to content

Remove namespace from executors#75

Merged
andygrove merged 1 commit intoapache:masterfrom
edrevo:remove-unnecessary-namespace
Apr 28, 2021
Merged

Remove namespace from executors#75
andygrove merged 1 commit intoapache:masterfrom
edrevo:remove-unnecessary-namespace

Conversation

@edrevo
Copy link
Copy Markdown
Contributor

@edrevo edrevo commented Apr 25, 2021

Which issue does this PR close?

Closes #66.

Are there any user-facing changes?

Yes. The namespace CLI option in the ballista executors disappear. This is actually good, since the description of that param was not in sync with the implementation.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #75 (33dfcc3) into master (35bc3d7) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   76.35%   76.36%           
=======================================
  Files         134      134           
  Lines       23018    23017    -1     
=======================================
  Hits        17576    17576           
+ Misses       5442     5441    -1     
Impacted Files Coverage Δ
ballista/rust/executor/src/main.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35bc3d7...33dfcc3. Read the comment docs.

@edrevo edrevo force-pushed the remove-unnecessary-namespace branch from 33dfcc3 to 5016ea4 Compare April 26, 2021 06:30
@alamb alamb requested a review from andygrove April 26, 2021 21:37
@alamb alamb added the ballista label Apr 26, 2021
Copy link
Copy Markdown
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question but LGTM.

Comment thread ballista/rust/executor/src/main.rs
@andygrove
Copy link
Copy Markdown
Member

@edrevo Please rebase and we can merge this one. Thanks!

@edrevo edrevo force-pushed the remove-unnecessary-namespace branch from 5016ea4 to 3b64387 Compare April 27, 2021 18:49
@edrevo
Copy link
Copy Markdown
Contributor Author

edrevo commented Apr 27, 2021

done!

@andygrove andygrove merged commit af4c05d into apache:master Apr 28, 2021
@edrevo edrevo deleted the remove-unnecessary-namespace branch June 11, 2021 09:35
@houqp houqp added api change Changes the API exposed to users of the crate bug Something isn't working and removed api change Changes the API exposed to users of the crate labels Jul 29, 2021
ewgenius pushed a commit to ewgenius/datafusion that referenced this pull request Apr 23, 2025
aditanase pushed a commit to hstack/datafusion that referenced this pull request May 18, 2025
UPSTREAM NOTE: This was submitted upstream:
apache#15814 and will be in DF 48
H0TB0X420 pushed a commit to H0TB0X420/datafusion that referenced this pull request Oct 7, 2025
LiaCastaneda added a commit to LiaCastaneda/datafusion that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change Changes the API exposed to users of the crate bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unnecessary references to namespace in executor

5 participants