Add Ballista support to DataFusion CLI#889
Merged
andygrove merged 15 commits intoapache:masterfrom Aug 16, 2021
Merged
Conversation
houqp
approved these changes
Aug 15, 2021
Member
|
looks like code blocks in readme needs to be marked with |
Member
|
my bad, |
alamb
approved these changes
Aug 16, 2021
Contributor
alamb
left a comment
There was a problem hiding this comment.
I looked at the code and it looks good to me. I think we have reasonable CI test coverage for the datafusion-cli (as it is used in the python integration test suite that @jimexist started).
Thanks @andygrove
| .map_err(|e| DataFusionError::Execution(format!("{:?}", e)))?; | ||
| Ok(Context::Remote(BallistaContext::remote(h, p, &config))) | ||
| } | ||
| _ => Ok(Context::Local(ExecutionContext::with_config( |
Member
|
Sorry that I've been quite busy these days. Will review by end of the week and also see what else i can contribute to. This is exciting! |
H0TB0X420
pushed a commit
to H0TB0X420/datafusion
that referenced
this pull request
Oct 7, 2025
* make script shebangs more flexible * move location of python tests This change allows us to run the test suite against a release candidate hosted on test.pypi.org. ``` pip install --extra-index-url https://test.pypi.org/simple/ datafusion==40.0.0 pytest --import-mode=importlib python/tests ``` * add documentation for testing against release candidate * add dev script for cleaning maturin build artifacts * update ruff lint config for new test location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #886 .
Rationale for this change
Enables a SQL repl for Ballista with minimal effort.
What changes are included in this PR?
datafusion-cli now has new
hostandportargumentsAre there any user-facing changes?
No