Skip to content

Commit 2e44b72

Browse files
authored
chore: remove mentions of compatibility with go toolchain < go1.18 (#760)
The github.com/apache/arrow/go/v11/arrow/compute module was removed in commit f6e3442, making it part of the main module. The go version in go.mod was updated to go1.18, but older versions of the go toolchain could still be used; > Requirements > > Despite the go.mod stating go1.18, everything except for the compute package > is able to be built with go1.17 (and most is also compatible with go1.16). Before Go 1.21, the go line in go.mod was effectively advisory: older toolchains might still try to build the module, and only complain if they hit something unsupported. Starting with Go 1.21 (backported to go1.19.3 and go1.20.8), the go line became a strict minimum requirement. https://go.dev/doc/go1.21 Commit ddfa815 updated the go version in go.mod to go1.21.0, no longer allowing older toolchains to be used. This patch removes the mentions of older toolchains. ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent 786d91a commit 2e44b72

3 files changed

Lines changed: 2 additions & 10 deletions

File tree

arrow/compute/doc.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,14 @@
1515
// limitations under the License.
1616

1717
// Package compute is a native-go implementation of an Acero-like
18-
// arrow compute engine. It requires go1.18+
18+
// arrow compute engine.
1919
//
2020
// While consumers of Arrow that are able to use CGO could utilize the
2121
// C Data API (using the cdata package) and could link against the
2222
// acero library directly, there are consumers who cannot use CGO. This
2323
// is an attempt to provide for those users, and in general create a
2424
// native-go arrow compute engine.
2525
//
26-
// The overwhelming majority of things in this package require go1.18 as
27-
// it utilizes generics. The files in this package and its sub-packages
28-
// are all excluded from being built by go versions lower than 1.18 so
29-
// that the larger Arrow module itself is still compatible with go1.17.
30-
//
3126
// Everything in this package should be considered Experimental for now.
3227
package compute
3328

arrow/compute/internal/kernels/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@
1515
// limitations under the License.
1616

1717
// Package kernels defines all of the computation kernels for the compute
18-
// library. This requires >= go1.18 since it utilizes Go generics.
18+
// library.
1919
package kernels

parquet/doc.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@
2020
// shredding and assembly algorithm to accommodate complex data structures which
2121
// can then be used to efficiently store the data.
2222
//
23-
// While the go.mod states go1.18, everything here should be compatible
24-
// with go versions 1.17 and 1.16.
25-
//
2623
// This implementation is a native go implementation for reading and writing the
2724
// parquet file format.
2825
//

0 commit comments

Comments
 (0)