fix arraydata equal func

Author: zeroshade

arrow/array.go

@@ -83,6 +83,8 @@ type ArrayData interface {
 	Dictionary() ArrayData
 	// SizeInBytes returns the size of the ArrayData buffers and any children and/or dictionary in bytes.
 	SizeInBytes() uint64
+
+	Equal(ArrayData) bool
 }
 
 // Array represents an immutable sequence of values using the Arrow in-memory format.

arrow/array/data.go

@@ -17,6 +17,7 @@
 package array
 
 import (
+	"bytes"
 	"hash/maphash"
 	"math/bits"
 	"sync/atomic"
@@ -77,6 +78,59 @@ func NewDataWithDictionary(dtype arrow.DataType, length int, buffers []*memory.B
 	return data
 }
 
+func (d *Data) Equal(other arrow.ArrayData) bool {
+	rhs, ok := other.(*Data)
+	if !ok {
+		return false
+	}
+
+	if d == rhs {
+		return true
+	}
+
+	switch {
+	case !arrow.TypeEqual(d.dtype, rhs.dtype):
+		return false
+	case d.length != rhs.length || d.nulls != rhs.nulls || d.offset != rhs.offset:
+		return false
+	case len(d.buffers) != len(rhs.buffers):
+		return false
+	case len(d.childData) != len(rhs.childData):
+		return false
+	case d.dictionary != nil && rhs.dictionary == nil:
+		return false
+	case d.dictionary == nil && rhs.dictionary != nil:
+		return false
+	}
+
+	if d.dictionary != nil {
+		if !d.dictionary.Equal(rhs.dictionary) {
+			return false
+		}
+	}
+
+	for i := range d.childData {
+		if !d.childData[i].Equal(rhs.childData[i]) {
+			return false
+		}
+	}
+
+	for i, b := range d.buffers {
+		switch {
+		case b == nil:
+			if rhs.buffers[i] != nil {
+				return false
+			}
+		case rhs.buffers[i] == nil:
+			return false
+		case !bytes.Equal(b.Bytes(), rhs.buffers[i].Bytes()):
+			return false
+		}
+	}
+
+	return true
+}
+
 func (d *Data) Copy() *Data {
 	// don't pass the slices directly, otherwise it retains the connection
 	// we need to make new slices and populate them with the same pointers

arrow/compute/exec/span_test.go

@@ -406,7 +406,8 @@ func TestArraySpan_MakeData(t *testing.T) {
 				}
 				got := a.MakeData()
 				want := tt.want(mem)
-				if !reflect.DeepEqual(got, want) {
+
+				if !got.Equal(want) {
 					t.Errorf("ArraySpan.MakeData() = %v, want %v", got, want)
 				}
 				want.Release()