optimization: comparison: when DataType is static, skip reflection

Noam Preil · Noam Preil · commit f33877c61a0d · 2025-10-23T15:19:51.000-05:00
diff --git a/arrow/compare.go b/arrow/compare.go
@@ -45,8 +45,10 @@ func TypeEqual(left, right DataType, opts ...TypeEqualOption) bool {
 	}
 
 	switch {
+	case left == right:
+		return true
 	case left == nil || right == nil:
-		return left == nil && right == nil
+		return false
 	case left.ID() != right.ID():
 		return false
 	}

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,10 @@ func TypeEqual(left, right DataType, opts ...TypeEqualOption) bool {`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`switch {`
	`48`	`+ case left == right:`
	`49`	`+ return true`
`48`	`50`	`case left == nil \|\| right == nil:`
`49`		`- return left == nil && right == nil`
	`51`	`+ return false`
`50`	`52`	`case left.ID() != right.ID():`
`51`	`53`	`return false`
`52`	`54`	`}`