Skip to content

Commit 3508674

Browse files
authored
Update MIRI for split crates (#2594) (#3754)
1 parent 57f79c0 commit 3508674

File tree

5 files changed

+9
-2
lines changed

5 files changed

+9
-2
lines changed

.github/workflows/miri.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,7 @@ cargo miri setup
1414
cargo clean
1515

1616
echo "Starting Arrow MIRI run..."
17-
cargo miri test -p arrow -- --skip csv --skip ipc --skip json
17+
cargo miri test -p arrow-buffer
18+
cargo miri test -p arrow-data --features ffi
19+
cargo miri test -p arrow-schema --features ffi
20+
cargo miri test -p arrow-array

arrow-array/src/array/boolean_array.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -542,6 +542,7 @@ mod tests {
542542
}
543543

544544
#[test]
545+
#[cfg_attr(miri, ignore)] // Takes too long
545546
fn test_true_false_count() {
546547
let mut rng = thread_rng();
547548

arrow-array/src/array/run_array.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -881,6 +881,7 @@ mod tests {
881881
}
882882

883883
#[test]
884+
#[cfg_attr(miri, ignore)] // Takes too long
884885
fn test_get_physical_indices() {
885886
// Test for logical lengths starting from 10 to 250 increasing by 10
886887
for logical_len in (0..250).step_by(10) {
@@ -917,6 +918,7 @@ mod tests {
917918
}
918919

919920
#[test]
921+
#[cfg_attr(miri, ignore)] // Takes too long
920922
fn test_get_physical_indices_sliced() {
921923
let total_len = 80;
922924
let input_array = build_input_array(total_len);

arrow-array/src/run_iterator.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,7 @@ mod tests {
349349
}
350350

351351
#[test]
352+
#[cfg_attr(miri, ignore)] // Takes too long
352353
fn test_sliced_run_array_iterator() {
353354
let total_len = 80;
354355
let input_array = build_input_array(total_len);

arrow-buffer/src/bigint.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,7 @@ impl ToPrimitive for i256 {
549549
}
550550
}
551551

552-
#[cfg(test)]
552+
#[cfg(all(test, not(miri)))] // llvm.x86.subborrow.64 not supported by MIRI
553553
mod tests {
554554
use super::*;
555555
use num::{BigInt, FromPrimitive, Signed, ToPrimitive};

0 commit comments

Comments
 (0)