chore: delete wrong comment and refactor set_metadata in Field (#3630)

chunshao90 · web-flow · commit 3c8d8db68fdb · 2023-01-30T06:24:27.000Z
diff --git a/arrow-schema/src/field.rs b/arrow-schema/src/field.rs
@@ -142,13 +142,9 @@ impl Field {
     }
 
     /// Sets the `Field`'s optional custom metadata.
-    /// The metadata is set as `None` for empty map.
     #[inline]
     pub fn set_metadata(&mut self, metadata: HashMap<String, String>) {
-        self.metadata = HashMap::default();
-        if !metadata.is_empty() {
-            self.metadata = metadata;
-        }
+        self.metadata = metadata;
     }
 
     /// Sets the metadata of this `Field` to be `metadata` and returns self

Original file line number	Diff line number	Diff line change
`@@ -142,13 +142,9 @@ impl Field {`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	/// Sets the `Field`'s optional custom metadata.
`145`		- /// The metadata is set as `None` for empty map.
`146`	`145`	`#[inline]`
`147`	`146`	`pub fn set_metadata(&mut self, metadata: HashMap<String, String>) {`
`148`		`- self.metadata = HashMap::default();`
`149`		`- if !metadata.is_empty() {`
`150`		`- self.metadata = metadata;`
`151`		`- }`
	`147`	`+ self.metadata = metadata;`
`152`	`148`	`}`
`153`	`149`
`154`	`150`	/// Sets the metadata of this `Field` to be `metadata` and returns self