Skip to content

Commit 98ce68f

Browse files
askoaask
andauthored
fix take_run benchmark paraeter (#3679)
Co-authored-by: ask <ask@local>
1 parent 7cd29d7 commit 98ce68f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

arrow/benches/primitive_run_take.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ use arrow_array::UInt32Array;
2424
use criterion::{criterion_group, criterion_main, Criterion};
2525
use rand::Rng;
2626

27-
fn create_random_index(size: usize, null_density: f32) -> UInt32Array {
27+
fn create_random_index(size: usize, null_density: f32, max_value: usize) -> UInt32Array {
2828
let mut rng = seedable_rng();
2929
let mut builder = UInt32Builder::with_capacity(size);
3030
for _ in 0..size {
3131
if rng.gen::<f32>() < null_density {
3232
builder.append_null();
3333
} else {
34-
let value = rng.gen_range::<u32, _>(0u32..size as u32);
34+
let value = rng.gen_range::<u32, _>(0u32..max_value as u32);
3535
builder.append_value(value);
3636
}
3737
}
@@ -48,7 +48,7 @@ fn criterion_benchmark(c: &mut Criterion) {
4848
logical_array_len,
4949
physical_array_len,
5050
);
51-
let indices = create_random_index(take_len, 0.0);
51+
let indices = create_random_index(take_len, 0.0, logical_array_len);
5252
group.bench_function(
5353
format!(
5454
"(run_array_len:{logical_array_len}, physical_array_len:{physical_array_len}, take_len:{take_len})"),

0 commit comments

Comments
 (0)