Skip to content

Commit bbda7c1

Browse files
committed
Bump org.apache.commons:commons-parent from 96 to 97.
Fix PMD UnconditionalIfStatement
1 parent 3437902 commit bbda7c1

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<parent>
2121
<groupId>org.apache.commons</groupId>
2222
<artifactId>commons-parent</artifactId>
23-
<version>96</version>
23+
<version>97</version>
2424
</parent>
2525
<artifactId>commons-imaging</artifactId>
2626
<name>Apache Commons Imaging</name>

src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@ public class GifImageParser extends AbstractImageParser<GifImagingParameters> im
8484
0x50, // P
8585
};
8686

87+
private static final boolean LOCAL_COLOR_TABLE_FLAG = true;
88+
8789
// Made internal for testability.
8890
static DisposalMethod createDisposalMethodFromIntValue(final int value) throws ImagingException {
8991
switch (value) {
@@ -959,7 +961,6 @@ public void writeImage(final BufferedImage src, final OutputStream os, GifImagin
959961
bos.write2Bytes(height); // Image Height
960962

961963
{
962-
final boolean localColorTableFlag = true;
963964
// boolean LocalColorTableFlag = false;
964965
final boolean interlaceFlag = false;
965966
final boolean sortFlag = false;
@@ -968,7 +969,7 @@ public void writeImage(final BufferedImage src, final OutputStream os, GifImagin
968969
// int SizeOfLocalColorTable = 0;
969970

970971
final int packedFields;
971-
if (localColorTableFlag) {
972+
if (LOCAL_COLOR_TABLE_FLAG) {
972973
packedFields = LOCAL_COLOR_TABLE_FLAG_MASK | (interlaceFlag ? INTERLACE_FLAG_MASK : 0) | (sortFlag ? SORT_FLAG_MASK : 0)
973974
| 7 & sizeOfLocalColorTable;
974975
} else {

0 commit comments

Comments
 (0)