Skip to content

Commit eda636b

Browse files
committed
Javadoc: The @deprecated tag should be last.
1 parent e17ad8b commit eda636b

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/main/java/org/apache/commons/net/ftp/FTPClient.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1507,9 +1507,9 @@ public int getBufferSize() {
15071507
/**
15081508
* Gets how long to wait for control keep-alive message replies.
15091509
*
1510-
* @deprecated Use {@link #getControlKeepAliveReplyTimeoutDuration()}.
15111510
* @return wait time in milliseconds.
15121511
* @since 3.0
1512+
* @deprecated Use {@link #getControlKeepAliveReplyTimeoutDuration()}.
15131513
*/
15141514
@Deprecated
15151515
public int getControlKeepAliveReplyTimeout() {
@@ -1532,9 +1532,9 @@ public Duration getControlKeepAliveReplyTimeoutDuration() {
15321532
* See the class Javadoc section "Control channel keep-alive feature"
15331533
* </p>
15341534
*
1535-
* @deprecated Use {@link #getControlKeepAliveTimeoutDuration()}.
15361535
* @return the number of seconds between keepalive messages.
15371536
* @since 3.0
1537+
* @deprecated Use {@link #getControlKeepAliveTimeoutDuration()}.
15381538
*/
15391539
@Deprecated
15401540
public long getControlKeepAliveTimeout() {
@@ -1579,8 +1579,8 @@ public CopyStreamListener getCopyStreamListener() {
15791579
* <li>Number of IOErrors ignored</li>
15801580
* </ul>
15811581
*
1582-
* @deprecated 3.7 For testing only; may be dropped or changed at any time
15831582
* @return the debug array
1583+
* @deprecated 3.7 For testing only; may be dropped or changed at any time
15841584
*/
15851585
@Deprecated // only for use in testing
15861586
public int[] getCslDebug() {
@@ -2952,10 +2952,10 @@ public void setControlKeepAliveReplyTimeout(final Duration timeout) {
29522952
/**
29532953
* Sets the duration to wait for control keep-alive message replies.
29542954
*
2955-
* @deprecated Use {@link #setControlKeepAliveReplyTimeout(Duration)}.
29562955
* @param timeoutMillis number of milliseconds to wait (defaults to 1,000).
29572956
* @since 3.0
29582957
* @see #setControlKeepAliveTimeout(long)
2958+
* @deprecated Use {@link #setControlKeepAliveReplyTimeout(Duration)}.
29592959
*/
29602960
@Deprecated
29612961
public void setControlKeepAliveReplyTimeout(final int timeoutMillis) {
@@ -2982,10 +2982,10 @@ public void setControlKeepAliveTimeout(final Duration controlIdle) {
29822982
* See the class Javadoc section "Control channel keep-alive feature"
29832983
* </p>
29842984
*
2985-
* @deprecated Use {@link #setControlKeepAliveTimeout(Duration)}.
29862985
* @param controlIdleSeconds the wait in seconds between keepalive messages. Zero (or less) disables.
29872986
* @since 3.0
29882987
* @see #setControlKeepAliveReplyTimeout(int)
2988+
* @deprecated Use {@link #setControlKeepAliveTimeout(Duration)}.
29892989
*/
29902990
@Deprecated
29912991
public void setControlKeepAliveTimeout(final long controlIdleSeconds) {
@@ -3023,8 +3023,8 @@ public void setDataTimeout(final Duration timeout) {
30233023
* <strong>Note:</strong> the timeout will also be applied when calling accept() whilst establishing an active local data connection.
30243024
* </p>
30253025
*
3026-
* @deprecated Use {@link #setDataTimeout(Duration)}.
30273026
* @param timeoutMillis The default timeout in milliseconds that is used when opening a data connection socket. The value 0 means an infinite timeout.
3027+
* @deprecated Use {@link #setDataTimeout(Duration)}.
30283028
*/
30293029
@Deprecated
30303030
public void setDataTimeout(final int timeoutMillis) {
@@ -3214,8 +3214,8 @@ public void setPassiveLocalIPAddress(final String ipAddress) throws UnknownHostE
32143214
* The default is true, i.e. site-local replies are replaced.
32153215
* </p>
32163216
*
3217-
* @deprecated (3.6) use {@link #setPassiveNatWorkaroundStrategy(HostnameResolver)} instead
32183217
* @param enabled true to enable replacing internal IP's in passive mode.
3218+
* @deprecated (3.6) use {@link #setPassiveNatWorkaroundStrategy(HostnameResolver)} instead
32193219
*/
32203220
@Deprecated
32213221
public void setPassiveNatWorkaround(final boolean enabled) {

src/main/java/org/apache/commons/net/nntp/NNTPClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -751,9 +751,9 @@ public BufferedReader retrieveArticle(final String articleId, final ArticleInfo
751751
/**
752752
* @param articleId The unique article identifier of the article to retrieve
753753
* @param pointer A parameter through which to return the article's number and unique id
754-
* @deprecated 3.0 use {@link #retrieveArticle(String, ArticleInfo)} instead
755754
* @return A DotTerminatedMessageReader instance from which the article can be read. null if the article does not exist.
756755
* @throws IOException on error
756+
* @deprecated 3.0 use {@link #retrieveArticle(String, ArticleInfo)} instead
757757
*/
758758
@Deprecated
759759
public Reader retrieveArticle(final String articleId, final ArticlePointer pointer) throws IOException {

src/main/java/org/apache/commons/net/util/Base64.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@
4242
* compatible with the lower 127 ASCII chart (ISO-8859-1, Windows-1252, UTF-8, etc).
4343
* </p>
4444
*
45-
* @deprecated Use {@link java.util.Base64}.
4645
* @see <a href="https://www.ietf.org/rfc/rfc2045.txt">RFC 2045</a>
4746
* @since 2.2
47+
* @deprecated Use {@link java.util.Base64}.
4848
*/
4949
@Deprecated
5050
public class Base64 {

0 commit comments

Comments
 (0)