Skip to content

Commit 2f64b60

Browse files
authored
chore: Run Spark SQL tests with native_datafusion in CI (#3393)
1 parent d28d0e0 commit 2f64b60

3 files changed

Lines changed: 590 additions & 100 deletions

File tree

.github/workflows/spark_sql_test.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,13 +120,13 @@ jobs:
120120
# - auto scan: all Spark versions (3.4, 3.5, 4.0)
121121
# - native_iceberg_compat: Spark 3.5 only
122122
config:
123-
- {spark-short: '3.4', spark-full: '3.4.3', java: 11, scan-impl: 'auto', scan-env: ''}
124-
- {spark-short: '3.5', spark-full: '3.5.8', java: 11, scan-impl: 'auto', scan-env: ''}
125-
- {spark-short: '3.5', spark-full: '3.5.8', java: 11, scan-impl: 'native_iceberg_compat', scan-env: 'COMET_PARQUET_SCAN_IMPL=native_iceberg_compat'}
126-
- {spark-short: '4.0', spark-full: '4.0.1', java: 17, scan-impl: 'auto', scan-env: ''}
123+
- {spark-short: '3.4', spark-full: '3.4.3', java: 11, scan-impl: 'auto'}
124+
- {spark-short: '3.5', spark-full: '3.5.8', java: 11, scan-impl: 'auto'}
125+
- {spark-short: '3.5', spark-full: '3.5.8', java: 11, scan-impl: 'native_datafusion'}
126+
- {spark-short: '4.0', spark-full: '4.0.1', java: 17, scan-impl: 'auto'}
127127
# Skip sql_hive-1 for Spark 4.0 due to https://github.com/apache/datafusion-comet/issues/2946
128128
exclude:
129-
- config: {spark-short: '4.0', spark-full: '4.0.1', java: 17, scan-impl: 'auto', scan-env: ''}
129+
- config: {spark-short: '4.0', spark-full: '4.0.1', java: 17, scan-impl: 'auto'}
130130
module: {name: "sql_hive-1", args1: "", args2: "hive/testOnly * -- -l org.apache.spark.tags.ExtendedHiveTest -l org.apache.spark.tags.SlowHiveTest"}
131131
fail-fast: false
132132
name: spark-sql-${{ matrix.config.scan-impl }}-${{ matrix.module.name }}/spark-${{ matrix.config.spark-full }}
@@ -155,7 +155,7 @@ jobs:
155155
run: |
156156
cd apache-spark
157157
rm -rf /root/.m2/repository/org/apache/parquet # somehow parquet cache requires cleanups
158-
ENABLE_COMET=true ENABLE_COMET_ONHEAP=true ${{ matrix.config.scan-env }} ENABLE_COMET_LOG_FALLBACK_REASONS=${{ github.event.inputs.collect-fallback-logs || 'false' }} \
158+
NOLINT_ON_COMPILE=true ENABLE_COMET=true ENABLE_COMET_ONHEAP=true COMET_PARQUET_SCAN_IMPL=${{ matrix.config.scan-impl }} ENABLE_COMET_LOG_FALLBACK_REASONS=${{ github.event.inputs.collect-fallback-logs || 'false' }} \
159159
build/sbt -Dsbt.log.noformat=true ${{ matrix.module.args1 }} "${{ matrix.module.args2 }}"
160160
if [ "${{ github.event.inputs.collect-fallback-logs }}" = "true" ]; then
161161
find . -type f -name "unit-tests.log" -print0 | xargs -0 grep -h "Comet cannot accelerate" | sed 's/.*Comet cannot accelerate/Comet cannot accelerate/' | sort -u > fallback.log

0 commit comments

Comments
 (0)