Commit 662a3ba
authored
fix: inverted null_percent logic in in_list benchmark (#19204)
## Which issue does this PR close?
N/A - benchmark fix discovered during performance analysis of #18832.
## Rationale for this change
The `in_list` benchmark (introduced in #4068) had inverted null
generation logic: `null_percent=0` was producing 100% nulls instead of
0% nulls.
## What changes are included in this PR?
Fix the `random_bool(null_percent).then(...)` pattern to use
`random_bool(1.0 - null_percent)` so that `null_percent` correctly
represents the percentage of null values.
## Are these changes tested?
Benchmark-only change. Verified by running the benchmark and observing
expected performance characteristics.
## Are there any user-facing changes?
No.1 parent 0812d27 commit 662a3ba
1 file changed
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
| 53 | + | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
55 | | - | |
| 57 | + | |
56 | 58 | | |
57 | 59 | | |
58 | 60 | | |
| |||
72 | 74 | | |
73 | 75 | | |
74 | 76 | | |
75 | | - | |
| 77 | + | |
76 | 78 | | |
77 | 79 | | |
78 | 80 | | |
| |||
87 | 89 | | |
88 | 90 | | |
89 | 91 | | |
90 | | - | |
| 92 | + | |
91 | 93 | | |
92 | 94 | | |
93 | 95 | | |
| |||
0 commit comments