Skip to content

Commit 4fbdc4f

Browse files
biyuhaoralf0131
authored andcommitted
Fix random ut falling in DubboMonitorTest (#3327)
1 parent c72708b commit 4fbdc4f

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

dubbo-monitor/dubbo-monitor-default/src/test/java/org/apache/dubbo/monitor/dubbo/DubboMonitorTest.java

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -103,22 +103,23 @@ public void testCount() throws Exception {
103103
.addParameter(MonitorService.CONCURRENT, 1)
104104
.addParameter(MonitorService.MAX_CONCURRENT, 1);
105105
monitor.collect(statistics);
106+
monitor.send();
106107
while (lastStatistics == null) {
107108
Thread.sleep(10);
108109
}
109-
Assertions.assertEquals(lastStatistics.getParameter(MonitorService.APPLICATION), "morgan");
110-
Assertions.assertEquals(lastStatistics.getProtocol(), "dubbo");
111-
Assertions.assertEquals(lastStatistics.getHost(), "10.20.153.10");
112-
Assertions.assertEquals(lastStatistics.getParameter(MonitorService.APPLICATION), "morgan");
113-
Assertions.assertEquals(lastStatistics.getParameter(MonitorService.INTERFACE), "MemberService");
114-
Assertions.assertEquals(lastStatistics.getParameter(MonitorService.METHOD), "findPerson");
115-
Assertions.assertEquals(lastStatistics.getParameter(MonitorService.CONSUMER), "10.20.153.11");
116-
Assertions.assertEquals(lastStatistics.getParameter(MonitorService.SUCCESS), "1");
117-
Assertions.assertEquals(lastStatistics.getParameter(MonitorService.FAILURE), "0");
118-
Assertions.assertEquals(lastStatistics.getParameter(MonitorService.ELAPSED), "3");
119-
Assertions.assertEquals(lastStatistics.getParameter(MonitorService.MAX_ELAPSED), "3");
120-
Assertions.assertEquals(lastStatistics.getParameter(MonitorService.CONCURRENT), "1");
121-
Assertions.assertEquals(lastStatistics.getParameter(MonitorService.MAX_CONCURRENT), "1");
110+
Assertions.assertEquals("morgan", lastStatistics.getParameter(MonitorService.APPLICATION));
111+
Assertions.assertEquals("dubbo", lastStatistics.getProtocol());
112+
Assertions.assertEquals("10.20.153.10", lastStatistics.getHost());
113+
Assertions.assertEquals("morgan", lastStatistics.getParameter(MonitorService.APPLICATION));
114+
Assertions.assertEquals("MemberService", lastStatistics.getParameter(MonitorService.INTERFACE));
115+
Assertions.assertEquals("findPerson", lastStatistics.getParameter(MonitorService.METHOD));
116+
Assertions.assertEquals("10.20.153.11", lastStatistics.getParameter(MonitorService.CONSUMER));
117+
Assertions.assertEquals("1", lastStatistics.getParameter(MonitorService.SUCCESS));
118+
Assertions.assertEquals("0", lastStatistics.getParameter(MonitorService.FAILURE));
119+
Assertions.assertEquals("3", lastStatistics.getParameter(MonitorService.ELAPSED));
120+
Assertions.assertEquals("3", lastStatistics.getParameter(MonitorService.MAX_ELAPSED));
121+
Assertions.assertEquals("1", lastStatistics.getParameter(MonitorService.CONCURRENT));
122+
Assertions.assertEquals("1", lastStatistics.getParameter(MonitorService.MAX_CONCURRENT));
122123
monitor.destroy();
123124
}
124125

0 commit comments

Comments
 (0)