Skip to content

Commit 8a8650f

Browse files
OrDTestersbeiwei30
authored andcommitted
Close all ports after tests finish (#2906)
1 parent 628ad77 commit 8a8650f

File tree

5 files changed

+27
-0
lines changed

5 files changed

+27
-0
lines changed

dubbo-rpc/dubbo-rpc-dubbo/src/test/java/org/apache/dubbo/rpc/protocol/dubbo/DubboInvokerAvilableTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import org.apache.dubbo.rpc.Exporter;
2727
import org.apache.dubbo.rpc.ProxyFactory;
2828
import org.apache.dubbo.rpc.protocol.dubbo.support.ProtocolUtils;
29+
import org.junit.AfterClass;
2930
import org.junit.Assert;
3031
import org.junit.Before;
3132
import org.junit.BeforeClass;
@@ -51,6 +52,11 @@ public static void setUpBeforeClass() throws Exception {
5152
public void setUp() throws Exception {
5253
}
5354

55+
@AfterClass
56+
public static void tearDownAfterClass() {
57+
ProtocolUtils.closeAll();
58+
}
59+
5460
@Test
5561
public void test_Normal_available() {
5662
URL url = URL.valueOf("dubbo://127.0.0.1:20883/org.apache.dubbo.rpc.protocol.dubbo.IDemoService");

dubbo-rpc/dubbo-rpc-dubbo/src/test/java/org/apache/dubbo/rpc/protocol/dubbo/DubboLazyConnectTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.apache.dubbo.common.utils.NetUtils;
2323
import org.apache.dubbo.rpc.RpcException;
2424
import org.apache.dubbo.rpc.protocol.dubbo.support.ProtocolUtils;
25+
import org.junit.AfterClass;
2526
import org.junit.Assert;
2627
import org.junit.Before;
2728
import org.junit.BeforeClass;
@@ -40,6 +41,11 @@ public static void setUpBeforeClass() throws Exception {
4041
public void setUp() throws Exception {
4142
}
4243

44+
@AfterClass
45+
public static void tearDownAfterClass() {
46+
ProtocolUtils.closeAll();
47+
}
48+
4349
@Test(expected = RpcException.class)
4450
public void testSticky1() {
4551
URL url = URL.valueOf("dubbo://127.0.0.1:9090/org.apache.dubbo.rpc.protocol.dubbo.IDemoService");

dubbo-rpc/dubbo-rpc-dubbo/src/test/java/org/apache/dubbo/rpc/protocol/dubbo/ExplicitCallbackTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ public class ExplicitCallbackTest {
4949
@After
5050
public void tearDown() {
5151
destroyService();
52+
ProtocolUtils.closeAll();
5253
}
5354

5455
public void exportService() {

dubbo-rpc/dubbo-rpc-dubbo/src/test/java/org/apache/dubbo/rpc/protocol/dubbo/MultiThreadTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
import org.apache.dubbo.rpc.ProxyFactory;
2424
import org.apache.dubbo.rpc.protocol.dubbo.support.DemoService;
2525
import org.apache.dubbo.rpc.protocol.dubbo.support.DemoServiceImpl;
26+
import org.apache.dubbo.rpc.protocol.dubbo.support.ProtocolUtils;
27+
import org.junit.After;
2628
import org.junit.Assert;
2729
import org.junit.Test;
2830

@@ -36,6 +38,11 @@ public class MultiThreadTest {
3638
private Protocol protocol = ExtensionLoader.getExtensionLoader(Protocol.class).getAdaptiveExtension();
3739
private ProxyFactory proxy = ExtensionLoader.getExtensionLoader(ProxyFactory.class).getAdaptiveExtension();
3840

41+
@After
42+
public void after() {
43+
ProtocolUtils.closeAll();
44+
}
45+
3946
@Test
4047
public void testDubboMultiThreadInvoke() throws Exception {
4148
Exporter<?> rpcExporter = protocol.export(proxy.getInvoker(new DemoServiceImpl(), DemoService.class, URL.valueOf("dubbo://127.0.0.1:20259/TestService")));

dubbo-rpc/dubbo-rpc-dubbo/src/test/java/org/apache/dubbo/rpc/protocol/dubbo/RpcFilterTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,22 @@
2222
import org.apache.dubbo.rpc.ProxyFactory;
2323
import org.apache.dubbo.rpc.protocol.dubbo.support.DemoService;
2424
import org.apache.dubbo.rpc.protocol.dubbo.support.DemoServiceImpl;
25+
import org.apache.dubbo.rpc.protocol.dubbo.support.ProtocolUtils;
2526
import org.apache.dubbo.rpc.service.EchoService;
2627

28+
import org.junit.After;
2729
import org.junit.Assert;
2830
import org.junit.Test;
2931

3032
public class RpcFilterTest {
3133
private Protocol protocol = ExtensionLoader.getExtensionLoader(Protocol.class).getAdaptiveExtension();
3234
private ProxyFactory proxy = ExtensionLoader.getExtensionLoader(ProxyFactory.class).getAdaptiveExtension();
3335

36+
@After
37+
public void after() {
38+
ProtocolUtils.closeAll();
39+
}
40+
3441
@Test
3542
public void testRpcFilter() throws Exception {
3643
DemoService service = new DemoServiceImpl();

0 commit comments

Comments
 (0)