Skip to content

Commit babf0d1

Browse files
kexianjuncarryxyh
authored andcommitted
simply telnet command enabled check logic (#3316)
* simply telnet command enabled check
1 parent b4aa515 commit babf0d1

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/TelnetHandlerAdapter.java

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -81,20 +81,17 @@ public String telnet(Channel channel, String message) throws RemotingException {
8181
}
8282

8383
private boolean commandEnabled(URL url, String command) {
84-
boolean commandEnable = false;
8584
String supportCommands = url.getParameter(Constants.TELNET);
8685
if (StringUtils.isEmpty(supportCommands)) {
87-
commandEnable = true;
88-
} else {
89-
String[] commands = Constants.COMMA_SPLIT_PATTERN.split(supportCommands);
90-
for (String c : commands) {
91-
if (command.equals(c)) {
92-
commandEnable = true;
93-
break;
94-
}
86+
return true;
87+
}
88+
String[] commands = Constants.COMMA_SPLIT_PATTERN.split(supportCommands);
89+
for (String c : commands) {
90+
if (command.equals(c)) {
91+
return true;
9592
}
9693
}
97-
return commandEnable;
94+
return false;
9895
}
9996

10097
}

0 commit comments

Comments
 (0)