Skip to content

Commit bb9fd69

Browse files
mercyblitzbeiwei30
authored andcommitted
Bug Fix & Enhancement (#2687)
* Polish #2235 #2251 apache/dubbo-spring-boot-project#243 * Fixed bugs and optimized imports * Remove local PropertySourcesUtils and re-use it from spring-context-extras * Add Test cases for YAML properties issues : apache/dubbo-spring-boot-project/issues/273 * Optimize imports using code-style template * Refactor Utilities class * Fixed test cases * [Enhancement] @EnableDubboConfigBinding annotates @repeatable #1770 * Bug fix * Remove feature : [Enhancement] @EnableDubboConfigBinding annotates @repeatable #1770
1 parent e0bf21a commit bb9fd69

File tree

63 files changed

+278
-475
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

63 files changed

+278
-475
lines changed

dependencies-bom/pom.xml

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
2+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
34
<modelVersion>4.0.0</modelVersion>
45

56
<parent>
@@ -29,8 +30,8 @@
2930
<url>https://github.com/apache/incubator-dubbo</url>
3031
<connection>scm:git:https://github.com/apache/incubator-dubbo.git</connection>
3132
<developerConnection>scm:git:https://github.com/apache/incubator-dubbo.git</developerConnection>
32-
<tag>HEAD</tag>
33-
</scm>
33+
<tag>HEAD</tag>
34+
</scm>
3435
<mailingLists>
3536
<mailingList>
3637
<name>Development List</name>
@@ -112,7 +113,8 @@
112113
<jaxb_version>2.2.7</jaxb_version>
113114
<activation_version>1.2.0</activation_version>
114115
<hessian_lite_version>3.2.4</hessian_lite_version>
115-
<alibaba_spring_context_support_version>1.0.1</alibaba_spring_context_support_version>
116+
<alibaba_spring_context_support_version>1.0.2</alibaba_spring_context_support_version>
117+
<yaml_version>1.17</yaml_version>
116118
</properties>
117119

118120
<dependencyManagement>
@@ -369,6 +371,13 @@
369371
<version>${alibaba_spring_context_support_version}</version>
370372
</dependency>
371373

374+
<!-- YAML -->
375+
<dependency>
376+
<groupId>org.yaml</groupId>
377+
<artifactId>snakeyaml</artifactId>
378+
<version>${yaml_version}</version>
379+
</dependency>
380+
372381
<!-- Test lib -->
373382
<dependency>
374383
<groupId>org.apache.curator</groupId>
@@ -382,6 +391,7 @@
382391
<version>${embedded_redis_version}</version>
383392
<scope>test</scope>
384393
</dependency>
394+
385395
</dependencies>
386396
</dependencyManagement>
387397

dubbo-config/dubbo-config-spring/pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,11 @@
132132
<artifactId>tomcat-embed-core</artifactId>
133133
<scope>test</scope>
134134
</dependency>
135+
<dependency>
136+
<groupId>org.yaml</groupId>
137+
<artifactId>snakeyaml</artifactId>
138+
<scope>test</scope>
139+
</dependency>
135140

136141
</dependencies>
137142
<build>

dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/ReferenceBean.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import com.alibaba.dubbo.config.annotation.Reference;
2626
import com.alibaba.dubbo.config.spring.extension.SpringExtensionFactory;
2727
import com.alibaba.dubbo.config.support.Parameter;
28+
2829
import org.springframework.beans.factory.BeanFactoryUtils;
2930
import org.springframework.beans.factory.DisposableBean;
3031
import org.springframework.beans.factory.FactoryBean;

dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/AbstractAnnotationConfigBeanBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
import java.lang.annotation.Annotation;
3131
import java.util.List;
3232

33-
import static com.alibaba.dubbo.config.spring.util.BeanFactoryUtils.getBeans;
34-
import static com.alibaba.dubbo.config.spring.util.BeanFactoryUtils.getOptionalBean;
33+
import static com.alibaba.spring.util.BeanFactoryUtils.getBeans;
34+
import static com.alibaba.spring.util.BeanFactoryUtils.getOptionalBean;
3535

3636
/**
3737
* Abstract Configurable {@link Annotation} Bean Builder

dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/AnnotationPropertyValuesAdapter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@
2323

2424
import java.lang.annotation.Annotation;
2525

26-
import static com.alibaba.dubbo.config.spring.util.AnnotationUtils.getAttributes;
26+
import static com.alibaba.spring.util.AnnotationUtils.getAttributes;
27+
2728

2829
/**
2930
* {@link Annotation} {@link PropertyValues} Adapter

dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/DubboConfigBindingBeanPostProcessor.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import com.alibaba.dubbo.config.spring.context.annotation.EnableDubboConfigBinding;
2323
import com.alibaba.dubbo.config.spring.context.properties.DefaultDubboConfigBinder;
2424
import com.alibaba.dubbo.config.spring.context.properties.DubboConfigBinder;
25+
2526
import org.apache.commons.logging.Log;
2627
import org.apache.commons.logging.LogFactory;
2728
import org.springframework.beans.BeansException;

dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ReferenceAnnotationBeanPostProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
import com.alibaba.dubbo.config.spring.ReferenceBean;
2121
import com.alibaba.dubbo.config.spring.ServiceBean;
2222
import com.alibaba.dubbo.config.spring.context.event.ServiceBeanExportedEvent;
23-
import com.alibaba.dubbo.config.spring.util.AnnotationUtils;
2423
import com.alibaba.spring.beans.factory.annotation.AnnotationInjectedBeanPostProcessor;
24+
import com.alibaba.spring.util.AnnotationUtils;
2525

2626
import org.springframework.beans.BeansException;
2727
import org.springframework.beans.factory.annotation.InjectionMetadata;

dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ReferenceBeanBuilder.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import com.alibaba.dubbo.config.ConsumerConfig;
2121
import com.alibaba.dubbo.config.annotation.Reference;
2222
import com.alibaba.dubbo.config.spring.ReferenceBean;
23+
2324
import org.springframework.beans.propertyeditors.StringTrimmerEditor;
2425
import org.springframework.context.ApplicationContext;
2526
import org.springframework.util.Assert;
@@ -30,8 +31,8 @@
3031
import java.beans.PropertyEditorSupport;
3132
import java.util.Map;
3233

33-
import static com.alibaba.dubbo.config.spring.util.BeanFactoryUtils.getOptionalBean;
34-
import static com.alibaba.dubbo.config.spring.util.ObjectUtils.of;
34+
import static com.alibaba.spring.util.BeanFactoryUtils.getOptionalBean;
35+
import static com.alibaba.spring.util.ObjectUtils.of;
3536
import static org.springframework.util.StringUtils.commaDelimitedListToStringArray;
3637

3738
/**

dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.alibaba.dubbo.config.annotation.Service;
2222
import com.alibaba.dubbo.config.spring.ServiceBean;
2323
import com.alibaba.dubbo.config.spring.context.annotation.DubboClassPathBeanDefinitionScanner;
24+
2425
import org.springframework.beans.BeansException;
2526
import org.springframework.beans.MutablePropertyValues;
2627
import org.springframework.beans.factory.BeanClassLoaderAware;
@@ -56,7 +57,7 @@
5657
import java.util.List;
5758
import java.util.Set;
5859

59-
import static com.alibaba.dubbo.config.spring.util.ObjectUtils.of;
60+
import static com.alibaba.spring.util.ObjectUtils.of;
6061
import static org.springframework.beans.factory.support.BeanDefinitionBuilder.rootBeanDefinition;
6162
import static org.springframework.context.annotation.AnnotationConfigUtils.CONFIGURATION_BEAN_NAME_GENERATOR;
6263
import static org.springframework.core.annotation.AnnotationUtils.findAnnotation;

dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ServiceBeanNameBuilder.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@
2020
import com.alibaba.dubbo.config.annotation.Service;
2121
import com.alibaba.dubbo.config.spring.ReferenceBean;
2222
import com.alibaba.dubbo.config.spring.ServiceBean;
23+
2324
import org.springframework.core.env.Environment;
2425
import org.springframework.util.StringUtils;
2526

2627
import static com.alibaba.dubbo.config.spring.util.AnnotationUtils.resolveInterfaceName;
2728

29+
2830
/**
2931
* Dubbo {@link Service @Service} Bean Builder
3032
*

0 commit comments

Comments
 (0)