Skip to content

Commit e234a89

Browse files
laddcntswstarplanet
authored andcommitted
[Dubbo-5688] Fix timeout error when publish config to nacos (#5689)
* Fix timeout bug when publish config to nacos * Add test case for publishConfig info
1 parent f09ac8c commit e234a89

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

dubbo-configcenter/dubbo-configcenter-nacos/src/main/java/org/apache/dubbo/configcenter/support/nacos/NacosDynamicConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ public boolean publishConfig(String key, String group, String content) {
260260
boolean published = false;
261261
String resolvedGroup = resolveGroup(group);
262262
try {
263-
String value = configService.getConfig(key, resolvedGroup, -1L);
263+
String value = configService.getConfig(key, resolvedGroup, DEFAULT_TIMEOUT);
264264
if (StringUtils.isNotEmpty(value)) {
265265
content = value + "," + content;
266266
}

dubbo-configcenter/dubbo-configcenter-nacos/src/test/java/org/apache/dubbo/configcenter/support/nacos/NacosDynamicConfigurationTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@
3636
import java.util.SortedSet;
3737
import java.util.concurrent.CountDownLatch;
3838

39+
import static org.junit.jupiter.api.Assertions.assertEquals;
40+
import static org.junit.jupiter.api.Assertions.assertTrue;
41+
3942

4043
/**
4144
* Unit test for nacos config center support
@@ -140,6 +143,16 @@ public static void setUp() {
140143
}
141144
}
142145

146+
@Test
147+
public void testPublishConfig() {
148+
String key = "user-service";
149+
String group = "org.apache.dubbo.service.UserService";
150+
String content = "test";
151+
152+
assertTrue(config.publishConfig(key, group, content));
153+
assertEquals("test", config.getProperties(key, group));
154+
}
155+
143156
@AfterAll
144157
public static void tearDown() {
145158

0 commit comments

Comments
 (0)