Skip to content

Commit faf3983

Browse files
biyuhaochickenlj
authored andcommitted
Merge pull request #3323, fix double-checked locking.
1 parent 21a608c commit faf3983

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

dubbo-metadata-report/dubbo-metadata-report-api/src/main/java/org/apache/dubbo/metadata/integration/MetadataReportService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public class MetadataReportService {
3838

3939
protected final Logger logger = LoggerFactory.getLogger(getClass());
4040

41-
private static MetadataReportService metadataReportService;
41+
private static volatile MetadataReportService metadataReportService;
4242
private static Object lock = new Object();
4343

4444
private MetadataReportFactory metadataReportFactory = ExtensionLoader.getExtensionLoader(MetadataReportFactory.class).getAdaptiveExtension();

dubbo-metadata-report/dubbo-metadata-report-api/src/main/java/org/apache/dubbo/metadata/support/AbstractMetadataReport.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ class MetadataReportRetry {
357357
protected final Logger logger = LoggerFactory.getLogger(getClass());
358358

359359
final ScheduledExecutorService retryExecutor = Executors.newScheduledThreadPool(0, new NamedThreadFactory("DubboRegistryFailedRetryTimer", true));
360-
ScheduledFuture retryScheduledFuture;
360+
volatile ScheduledFuture retryScheduledFuture;
361361
AtomicInteger retryCounter = new AtomicInteger(0);
362362
// retry task schedule period
363363
long retryPeriod;

0 commit comments

Comments
 (0)