Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3624 +/- ##
============================================
- Coverage 63.77% 63.69% -0.08%
Complexity 71 71
============================================
Files 712 713 +1
Lines 31450 31495 +45
Branches 5073 5076 +3
============================================
+ Hits 20057 20061 +4
- Misses 9103 9138 +35
- Partials 2290 2296 +6
Continue to review full report at Codecov.
|
Member
|
just wondering what's situation we need use socket proxy? if it's common usage, do we need apply similar change to other remoting module? |
zonghaishang
previously requested changes
Mar 12, 2019
Please check the way to get SOCKS_PROXY_PORT
zonghaishang
requested changes
Mar 12, 2019
Member
zonghaishang
left a comment
There was a problem hiding this comment.
Please check the way to get SOCKS_PROXY_PORT
added 2 commits
April 19, 2019 17:24
Contributor
Author
|
@zonghaishang replace System.getProperty to ConfigUtils.getProperty. please review again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
add socks5 proxy support for dubbo-remoting-netty4.
Brief changelog
Check the system property 'socks5ProxyHost' in org.apache.dubbo.remoting.transport.netty4.NettyClient#initChannel, if it exists, use the system property socks5ProxyHost and socks5ProxyPort to create a Socks5ProxyHandler and add it to the first location of the ChannelPipeline
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.