Skip to content

Complete xsd definition for ConfigCenterConfig.#3854

Merged
ralf0131 merged 1 commit intoapache:masterfrom
chickenlj:xsd-complement
Apr 11, 2019
Merged

Complete xsd definition for ConfigCenterConfig.#3854
ralf0131 merged 1 commit intoapache:masterfrom
chickenlj:xsd-complement

Conversation

@chickenlj
Copy link
Copy Markdown
Contributor

What is the purpose of the change

Complete xsd definition of ConfigCenterConfig to get rid of warning from IDE.

Brief changelog

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Copy Markdown
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request.

@ralf0131 ralf0131 merged commit af8ad8f into apache:master Apr 11, 2019
@cvictory cvictory added this to the 2.7.2 milestone May 28, 2019
@chickenlj chickenlj deleted the xsd-complement branch August 30, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants