Modify bin/apisix to support the SO_REUSEPORT#1085
Conversation
…generated nginx.conf file can open the reuseport configuration
Judgment logic:
1. If it is a mac system, do not open reuseport
2. If it is a linux system and the kernel version is higher than 3.9.0, then turn on the reuserport switch, and the reuseport option will be added when generating nginx.conf> configuration
bin/apisix
Outdated
| {% else %} {% --if enable_reuseport %} | ||
|
|
||
| {% for _, port in ipairs(stream_proxy.tcp or {}) do %} | ||
| listen {*port*}; |
There was a problem hiding this comment.
listen {*port*} {% if enable_reuseport then %} reuseport {% end %};
This style is simpler.
Test cases to be added after pull request # 1063 apache#1063
|
Strictly speaking, detect if a feature is available or not via kernel version is not reliable. Linux distributions may backport kernel patch to an old release (search for "SO_REUSEPORT backport for linux distribution"), not even mentioning self-patched kernel. I think a better solution is to allow the users to configure it, since they know better about their servers than us. Maybe we can enable this feature by default, because most of the servers have kernel newer than 3.9. |
|
Considering that the kernel version of the current production environment basically supports reuseport, I think it is more reasonable to open the REUSEPORT configuration file by default and supporting configuration it. |
|
I remember that there are two main pits in reuseport, one is the kernel version, and the other is the support of http2 and http3. |
this way is simpler. thx @spacewander @Miss-you Expect your new commit ^_^ |
…uction environment basically supports reuseport, I think it is more reasonable to open the REUSEPORT configuration file by default and supporting configuration it. So, it's a better solution is to allow the users to configure the 'enable_reuseport'.
|
@membphis @spacewander |
bin/apisix
Outdated
| with_module_status = with_module_status, | ||
| node_ssl_listen = 9443, -- default value | ||
| error_log = {level = "warn"}, | ||
| enable_reuseport = true, -- default true |
There was a problem hiding this comment.
the default value should be set in config.yaml, not here.
bin/apisix
Outdated
| if sys_conf["enable_reuseport"] == false then | ||
| enable_reuseport = false | ||
| end | ||
|
|
There was a problem hiding this comment.
we can use the enable_reuseport in config.yaml
|
waiting your test case ^_^ |
update apache/incubator-apisix
conf/config.yaml
Outdated
| enable_debug: false | ||
| enable_dev_mode: false # Sets nginx worker_processes to 1 if set to true | ||
| enable_reuseport: true # Enable nginx SO_REUSEPORT switch if set to true. | ||
| enable_reuseport: false # Enable nginx SO_REUSEPORT switch if set to true. |
There was a problem hiding this comment.
setting enable_reuseport false to verify that test cases are working.
There was a problem hiding this comment.
For testing, you can write a separate script to modify config.yaml.
Miss-you
force-pushed
the
master
branch
2 times, most recently
from
2b61386 to
56e1d97
Compare
Miss-you
force-pushed
the
master
branch
10 times, most recently
from
5a7ec3d to
62dc89d
Compare
…_runner.sh 1.fix issue 'can not find openresty' 2.remove function 'check_result' 3.fix .gitignore
|
ok, we can merge it to |
4 participants
NOTE: Please read the Contributing.md guidelines before submitting your patch:
https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
Summary
Modify bin/apisix to increase the capacity so that the generated nginx.conf file can open the reuseport configuration
Judgment logic:
1. If it is a mac system, do not open reuseport
2. If it is a linux system and the kernel version is higher than 3.9.0, then turn on the reuserport switch, and the reuseport option will be added when generating nginx.conf> configuration
Full changelog
bin/apisix
Issues resolved
Fix #342