Skip to content

Allow add custom shared dict#1367

Merged
moonming merged 3 commits intoapache:masterfrom
griffenliu:master
Mar 31, 2020
Merged

Allow add custom shared dict#1367
moonming merged 3 commits intoapache:masterfrom
griffenliu:master

Conversation

@griffenliu
Copy link
Copy Markdown
Contributor

NOTE: Please read the Contributing.md guidelines before submitting your patch:

https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one

Summary

Allows you to add custom shared dict through configuration

Full changelog

  • config.yaml : lua_shared_dicts
  • apisix

@moonming
Copy link
Copy Markdown
Member

If you need to add one shared dict, then you will using this shared dict in Lua code, right?
So is this PR works with custom plugin?

@griffenliu
Copy link
Copy Markdown
Contributor Author

If you need to add one shared dict, then you will using this shared dict in Lua code, right?
So is this PR works with custom plugin?

Yes, I need add some custom plugin. I used the mlcache library, which needs to add some shared caches.

@moonming
Copy link
Copy Markdown
Member

Got it.

conf/config.yaml Outdated
- 127.0.0.1
- 'unix:'
lua_shared_dicts:
ipc_shared_dict: 100m # custom shared cache
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be commented by default.

@moonming moonming merged commit 12677c3 into apache:master Mar 31, 2020
SaberMaster pushed a commit to SaberMaster/incubator-apisix that referenced this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants